Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#8146 closed patch

simon1dos midi sfx

Reported by: Kirben Owned by: SF/jamieson630
Priority: normal Component: Engine: AGOS
Keywords: Cc:
Game: Simon the Sorcerer 1

Description

simon1dos uses midi for sound effects and music, the attached patch from olki adds basic support for playing back the midi sound effects. The problem is we need to mix the midi sound effects in with the music. The original game seems to pause the music, play a sound effect and resume the music.

Ticket imported from: #652419. Ticket imported from: patches/251.

Attachments (1)

midisfx.patch (3.4 KB ) - added by Kirben 18 years ago.

Download all attachments as: .zip

Change History (7)

by Kirben, 18 years ago

Attachment: midisfx.patch added

comment:1 by Kirben, 18 years ago

A correction, I just compared original simon1dos more and it seems to run multiple MIDI tracks at once during sound effects.

comment:2 by SF/jamieson630, 18 years ago

Someone more familiar with Simon should make the decision on whether to accept this patch. Since I'm not familiar with the games and have not seen the original distros, I don't know if these changes put us closer to the behavior of the originals.

As far as running multiple MIDI tracks, if Simon does in fact have this requiremen, we should tie into the iMuse infrastructure. Part of the larger vision for iMuse is to remove its coupling to the Scumm engine, so that it is free to service any client. That will be some time in coming, but we're steadily moving closer.

comment:3 by Kirben, 18 years ago

The patch just adds support for reading simon1dos sound effect files and was just to allow you to try out the feature if needed, it disables the reset midi track code. The code should not be applied yet.

comment:4 by Kirben, 18 years ago

Patch as been added to cvs with hack to allow choice between midi music and midi sound effects. Could you please check my changes to reset_tracks() in simon/midi.cpp, I just skipped that function when midi sound effects are been used but I'm not sure if that is correct way to prevent repeats...

comment:5 by Kirben, 18 years ago

Status: newclosed

comment:6 by digitall, 2 years ago

Component: Engine: AGOS
Game: Simon the Sorcerer 1
Note: See TracTickets for help on using tickets.