Opened 17 years ago

Closed 17 years ago

Last modified 11 months ago

#7993 closed patch

Simon save directory

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: AGOS
Keywords: Cc:
Game: Simon the Sorcerer 1

Description

I noticed that the Simon games uses a different, more
primitive (older?) mechanism for deciding where to put
saved games. This patch should fix that.

Ticket imported from: #587694. Ticket imported from: patches/98.

Attachments (3)

simonsave.diff (2.1 KB ) - added by eriktorbjorn 17 years ago.
Patch made against a July 27 snapshot
simonsave.2.diff (2.2 KB ) - added by eriktorbjorn 17 years ago.
Corrected patch against a July 29 snapshot
simonsave.3.diff (3.8 KB ) - added by eriktorbjorn 17 years ago.
Revised patch against an August 2 snapshot

Download all attachments as: .zip

Change History (9)

by eriktorbjorn, 17 years ago

Attachment: simonsave.diff added

Patch made against a July 27 snapshot

by eriktorbjorn, 17 years ago

Attachment: simonsave.2.diff added

Corrected patch against a July 29 snapshot

comment:1 by eriktorbjorn, 17 years ago

I seem to have messed up the patch file somehow. This one
should work. (Famous last words.)

comment:2 by fingolfin, 17 years ago

You should *not* access g_scumm from Simon code. Rather, put
the shared code into a common helper function or common
class or something, which both Simon and Scumm share.

by eriktorbjorn, 17 years ago

Attachment: simonsave.3.diff added

Revised patch against an August 2 snapshot

comment:3 by eriktorbjorn, 17 years ago

I see your point. Would this patch be more acceptable? It
puts GetSavegameDir() in util.cpp instead. (Where it still
uses g_scumm, but that's only because I don't know any
better. It could easily be eliminated by adding a parameter
to the function.)

comment:4 by fingolfin, 17 years ago

Owner: set to fingolfin
Status: newclosed

comment:5 by fingolfin, 17 years ago

Thanks for your work, Erik. In the end I put this into the
(rather new) Engine class, where it can easily be
shared.

comment:6 by digitall, 11 months ago

Component: Engine: AGOS
Game: Simon the Sorcerer 1
Note: See TracTickets for help on using tickets.