Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#7111 closed defect (fixed)

Incorrect position in texts, not as the original

Reported by: SF/jomalin1 Owned by: criezy
Priority: normal Component: Engine: Drascula
Keywords: Cc:
Game: Drascula

Description

Attached one of the intro screen.

  • From Dosbox (the text appears centered, that's good, how it should be)
  • From ScummVM 1.8.0 (the text is not centered, giving a strange sensation)

I am using ScummVM 1.8.0 on Win7 64 bits

Ticket imported from: bugs/7111.

Attachments (2)

Dosbox.png (56.5 KB ) - added by SF/jomalin1 4 years ago.
ScummVM.png (56.3 KB ) - added by SF/jomalin1 4 years ago.

Download all attachments as: .zip

Change History (6)

by SF/jomalin1, 4 years ago

Attachment: Dosbox.png added

comment:1 by SF/jomalin1, 4 years ago

This is about the Spanish version, downloaded from the official website (now the game is free):
http://www.alcachofashop.com/product_info.php?products_id=32&language=es

comment:2 by criezy, 4 years ago

Owner: set to criezy

comment:3 by criezy, 4 years ago

Thank you.
There is actually a lot more differences in the way we center text compared to the original executable. You can notice it in all the dialogs during the game (when enable text and speech).

About 8 years ago we made a change to the way text centering is done and fix some bugs (including crashes or text being drawned out of the screen). However not all the changes made make sense. I tried to clean that and the new code results in text display that is much closer to what we see in DosBox, but not identical (for example on the intro screen for which you have attached screenshots, my new version is centered too perfectly while in DosBox it is slightly shifted to the right).

I will tried to look further to understand where the remaining differences come from. So I am keeping this bug open for now. But the new version should already be much better (you can test using a daily build from http://www.scummvm.org/downloads/#daily but you will need to wait for the next one).

comment:4 by criezy, 4 years ago

Resolution: fixed
Status: newclosed

comment:5 by criezy, 4 years ago

I dived into the original source code (and I will take that oportunity to thank again Emilio de Paz Aragón from Alcachofa Soft for sharing the source code of Drascula with us) and made sure that we now reproduce the exact same behaviour for text alignment.

I must say that original source code does some strange things (and I suspect some of those where not done on purpose such as adding a space at the end of the last line of text when a string is split into several lines, which impacts how that last line is aligned).

Note: See TracTickets for help on using tickets.