Opened 4 years ago

Closed 4 years ago

#7064 closed defect (fixed)

IHNM: text mistake in german version

Reported by: SF/windlepoons Owned by: eriktorbjorn
Priority: normal Component: Engine: SAGA
Keywords: Cc:
Game: I Have No Mouth

Description

Two text bugs in German version in the in-game option menu:

  1. text is black/dark but in DOSBox this is green/hover text red.
  2. the text in the left menu box is not centered.

http://i.imgur.com/4YuPhVQ.png

IHNM (DOS/German)
ScummVM 1.9.0git738-gb12cb73 (Feb 22 2016 07:05:46)

Ticket imported from: bugs/7064.

Attachments (1)

ihnm.png (19.1 KB ) - added by SF/windlepoons 4 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 by eriktorbjorn, 4 years ago

It looks like we have a workaround for this in engines/saga/saga.cpp, SagaEngine::KnownColor2ColorId(), but only for the Spanish version. Maybe it's enough to extend this to the German version? Probably the French as well. At least, I see the same problem with the French version from GOG.

comment:2 by sev-, 4 years ago

Yes, that would do it. Willing to help?

comment:3 by eriktorbjorn, 4 years ago

I think I've fixed the bug, and cherry-picked the fix into the 1.8 branch as well. There were actually two places where it worked around the colour for the Spanish version. The other affected the colour of the status line. (Actually I found a third one, which I think has to do with the spiritual barometer, but it appears that one really is only for the Spanish version.)

comment:4 by eriktorbjorn, 4 years ago

Owner: set to eriktorbjorn
Resolution: fixed
Status: newclosed

by SF/windlepoons, 4 years ago

Attachment: ihnm.png added

comment:5 by SF/windlepoons, 4 years ago

Thanks, the color mistake is fixed, but not the "(non) centered text" bug.

comment:6 by eriktorbjorn, 4 years ago

Resolution: fixed
Status: closednew

comment:7 by eriktorbjorn, 4 years ago

Ah, I got so caught up with the text colour that I completely missed the second part. Looks like it hard-codes the text position, rather than using the text centering feature.

comment:8 by SF/windlepoons, 4 years ago

ok, but i am confused. In DOSBox the text is centered. (first screenshot)

comment:9 by eriktorbjorn, 4 years ago

I don't doubt that. What I meant was that ScummVM, for whatever reason, hard-codes the text positions, even thought there seems to be a flag to the text renderer telling it to center the text.

The function to get the text position is called in a number of places, though, so fixing it might take a bit of time. (I'm not looking at this at the moment, so if there are any takers... :-)

comment:10 by eriktorbjorn, 4 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.