Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6553 closed defect

AGOS: Simon2 Amiga conversion detection wrong and assertion with speech files

Reported by: raziel- Owned by: Kirben
Priority: normal Component: Engine: AGOS
Version: Keywords:
Cc: Game: Simon the Sorcerer 2

Description

ScummVM 1.7.0git (Mar 7 2014 16:46:12) Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 Theora AAC FreeType2 JPEG PNG

The Amiga conversion of Simon the Sorcerer 2 - The Lion, the Wizard and the Wardrobe is detected wrong as Simon the Sorcerer 2 (CD/Windows/English) leading to unforseeable problems in later bug reports (Ahem) :-)

Here is a little more info on the version: http://hol.abime.net/1943

It reads "Amiga and Mac conversion done by Peter Mulholland and Paul Burkey" on the back of the jewel case and was published by Epic Marketing. Versions: complete english with german and italian subtitles. A later patch added french subtitles aswell. (The patch can be downloaded here, albeit only through web.archive: https://web.archive.org/web/20010302121045/http://www.shoecake.com/files/Simon2Upd5.lha) Maybe this patch can be put up on the ScummVM downloads page? System: AGA or GFX card 68030+, 16 MB Ram

AmigaOS4 - PPC - SDL - BE gcc (GCC) 4.2.4 (adtools build 20090118)

Following a list of files with md5sums from a fully installed game with the latest patch applied:

2082f8d02075e590300478853a91ffd9 tbllist e229f84d46fa83f99b4a7115679f3fb6 stripped.txt 1e42ee76c1adc04d10ee17268a22c3de simon2.italian a03bd98fca6f60b30300ce56a4363d77 Simon2.gme 744f020a127b0bc874ceb58ea2a76aaf simon2.german a08b90541afddb4382c425bac1b56f1b simon2.french b26f9530221d4182c0b0ca8d74d99473 simon2.english 1afea8f5b5cd8e5a56ff833fc4be0d89 simon2.dic ee92d1f84893195a60449f2430d07285 Icon.dat 5efc16d1c0eac67a7d2ec0900b02339a Mouse.dat bd85a8b5135592ada9cbeae49160f1d3 gsptr30 f4ca96062cd548e73fe3cb49cc53ae59 epic.tga 5c53c98218c624eb6c3966e6fa3dbf0a voices/voices9.dat 59d5e3277952d31da281b4f93ff0d623 voices/voices8.dat d6acc41085f8ffd6ae9cc74e2b4bfbd5 voices/voices7.dat e3f870eec719e7f68457a6b0104b7961 voices/voices6.dat 55bc10ac5fb3b28a00bd077fdccd8c52 voices/voices5.dat ffe4df580ee7b1b44b07adf5cdc66442 voices/voices4.dat 1835ef9701a084f7894893669a2cc3a8 voices/voices38.dat 9800df4d021977d574f6caf4b58d6bad voices/voices37.dat 446575a51c1409e97c9de0581ac4e4e6 voices/voices36.dat 413f6bf7d6170af2daa193d1852b6517 voices/voices35.dat 39689bcedaa4bb1576cb78a8b994e3ce voices/voices34.dat a30a85dd0aeee22b6ead83591a1fae26 voices/voices33.dat d50ee1e9cd8fb8e9d074f5c9721657d0 voices/voices32.dat c2b31f5ff2eb0dc85a90faa058fb4c83 voices/voices31.dat b5b9d48d2d5cb846313fbe01055d6cb3 voices/voices30.dat 9172038c2ff51605a2ae8e6e9f36507c voices/voices3.dat 4723feae18adeb2faf9ac611b3e54b35 voices/voices29.dat 4a1c0721e900d17f9343133ce8ebb634 voices/voices28.dat 8eb38d89c83d6f3cb5fb23349e779a38 voices/voices27.dat 53c4520705607d37a96938cf5e8f8381 voices/voices26.dat b45d2756aa90c7c2cd8757e7299f0293 voices/voices25.dat e8348731e8524d3a10ee416d3715430e voices/voices24.dat c1fb10429cbecdc63fe520c23fec6dc6 voices/voices23.dat a4451f67b3e730c400ad01098ea87cb6 voices/voices22.dat c166cafb21553c9a3bfe3497501b016c voices/voices21.dat 87417b40a9324f9a371a42f63b256968 voices/voices20.dat 43bdc3388e2cb9340ea1a50d200e9553 voices/voices2.dat 41538bd90418a7f97405957e0515dc2c voices/voices19.dat 18c1095f423302a41931a31c14755cac voices/voices18.dat d4d5e62a06d0bd9862ba90064dd00f65 voices/voices17.dat 1b4b89781d65083c6ae24673b9e95697 voices/voices16.dat b83a048105c3c73e10e4afb050609a89 voices/voices15.dat c7fe086502913c10825ff3768868b908 voices/voices14.dat 5283c9ba1fda586a0f2dc8fa591d2ebb voices/voices13.dat 8687220a17906ed33a9cc67b61886c73 voices/voices12.dat 7053044588ac92bd4ec83b9e4bf7ab4d voices/voices11.dat 8f301860dd8becea8ff10245954abb5f voices/voices10.dat 21f858bc78fd63ce46e4335662a93855 voices/voices1.dat 21bbbb3070e2965b1ed1ebf76048c29f voices/voices.idx

The only differences to a clean "off the CD" install is the missing simon2.french subtitle file and the file called "epic.tga" which seems to be an ad picture from the publisher (all the other updates were done to the Amiga executable).

Ticket imported from: bugs/6553.

Change History (10)

comment:1 by raziel-, 7 years ago

Following this report is the continuation of https://sourceforge.net/p/scummvm/bugs/6549/ which seems to be direcly affected by the wrong detector entry and may cause even more mischief later on.

Breakdown: assertion "_begin <= _end" failed: file "common/stream.cpp", line 213 in the intro of Simon 2 Amiga

c82a75df69aa5d8f36eae52deee508ef9a61e49e is the revision that breaks

comment:2 by digitall, 7 years ago

Summary: Simon 2: Amiga conversion detection wrong and assertion with speech filesAGOS: Simon2 Amiga conversion detection wrong and assertion with speech files

comment:3 by Kirben, 7 years ago

Owner: set to Kirben
Status: newclosed

comment:4 by Kirben, 7 years ago

The dictionary files used by the Amiga & Macintosh versions of Simon the Sorcerer 2 aren't supported, and are unlikely to be supported anytime soon. They contain the complete subtitles for the game in multiple languages, but in an unknown random order.

The other data files are identical to the Windows port, other than difference in speech files, which is already auto detected by ScummVM.

That is why we have not added specific detection entries, and they won't be added until dictionary support is possible in the future.

Closing as later.

comment:5 by wjp, 7 years ago

I don't quite see the connection between that argument and detecting this as a Windows version.

comment:6 by Kirben, 7 years ago

The dictionary files aren't used by ScummVM at all, and it isn't clear which files will be required. So it doesn't make any sense to make those files required by ScummVM at this stage.

comment:7 by raziel-, 7 years ago

I was wondering if i'm allowed to attach those dictionary files here for later inspection? At least the french subtitle file is/was freely available from the patches.

May i add them to this item?

comment:8 by wjp, 7 years ago

I'm very confused now. Why are the dictionary files relevant? We're currently detecting Mac/Amiga versions of Simon2 as the Windows version. That isn't right.

comment:9 by Kirben, 7 years ago

I already own the Amiga port of Simon the Sorcerer 2, and the know format used by the dictionary files. But order of the subtitles in the dictionary files seem completely random though, and don't match the string ids or speech ids in the game scripts. The problem is making use of those subtitles, without adding huge conversion tables for multiple languages.

The dictionary files are relevant for detection, because they would be the only way to detect between the Amiga/Macintosh ports and the Windows port. The other data files are identical to the Windows port, and the voice files can't be used for detection, since they could be compressed.

comment:10 by sev-, 7 years ago

I highly recommend to add correct detection entries for these versions, but probably display a message that they are not supported.

This will remove chance of such false positive bugreports to be submitted.

Note: See TracTickets for help on using tickets.