#6542 closed defect (fixed)
SCI: assertion in detector
| Reported by: | misterhands | Owned by: | bluegr |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCI |
| Version: | Keywords: | detection | |
| Cc: | Game: |
Description
Latest Win32 snapshot
When trying to add an uninstalled game (in this case, LB2 DOS floppy), I got this, as expected: WARNING: Failed to open volume file - if you got resource.p01/resource.p02/etc. files, merge them together into resource.000! WARNING: Volume version not detected, but map version has been detected. Setting volume version to map version!
And also an assertion error on "source" in resource.cpp:1690.
I remember getting this before, when doing a mass-add on a KQ collection CD. It seems to occur whenever there is a RESOURCE.MAP file in a directory, but no volume file (ie RESOURCE.00x).
Ticket imported from: bugs/6542.
Change History (5)
comment:1 by , 10 years ago
| Keywords: | detection added |
|---|---|
| Owner: | set to |
| Resolution: | → fixed |
| Status: | new → closed |
comment:2 by , 10 years ago
comment:3 by , 10 years ago
Hi Filippos! This is still occurring for me on the 2 mentioned test cases:
WARNING: Failed to open volume file - if you got resource.p01/resource.p02/etc. files, merge them together into resource.000! Assertion failed: source, file engines/sci/resource.cpp, line 1710
comment:5 by , 10 years ago
Sure, the RESOURCE.* files for LB2 are: RESOURCE.AUD RESOURCE.CFG RESOURCE.MAP RESOURCE.MSG RESOURCE.P01 RESOURCE.P02 RESOURCE.P03 RESOURCE.P04
But I can get the same assert error with only the MAP file present in the directory.
This has been fixed with the latest changes to the SCI fallback detector (commit fe3ed8ded2, bug #6717). The fix should be available in the next daily release of ScummVM.
I have tried locally with both a valid and an invalid resource.map file, with and without a resource.000 file, and all these cases work fine without any assertion anymore.
Closing as fixed