Opened 7 years ago

Closed 7 years ago

#6056 closed defect (fixed)

SCI: KQ5 Floppy English detected as Polish

Reported by: misterhands Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: detection Cc:
Game: King's Quest 5


SCUMMVM 1.5git win32
KQ V version is 0.000.051 and that's the vanilla floppy English release. No Polish inside.
I see there is another 0.000.051 version in the detection tables... must be a variant.

The detection entries have been originally reported in bug #2725722.
My guess is that the guy made a mistake and posted the English md5 instead of the Polish ones,
as it seems unlikely that the English and Polish versions would have the same exact file sizes and md5sums.

Ticket imported from: #3536863. Ticket imported from: bugs/6056.

Attachments (1)

KQV.md5 (1.8 KB) - added by misterhands 7 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 7 years ago by digitall

The bug referred to is "SCI: Kings Quest V PC Polish version md5's - ID: 2725722" :

This provided md5sums for the resource.nnn and files, but the official translation may exist only as patch files or may only result in changes to these files after the 5000 byte detection limit.

misterhands: Could you please attach a textfile to this bug with a file listing of your KQ5 Floppy English datafiles along with full file md5sums? The output of a tool such as would be optimal.

comment:2 Changed 7 years ago by digitall

Summary: SCI :KQV Floppy English detected as PolishSCI: KQ5 Floppy English detected as Polish

comment:3 Changed 7 years ago by misterhands

Yeah it could be a translation thing, meaning that the md5sums are indeed from the English Floppy release, and the Polish version adds translation patch files on top.
Given that the file sizes are identical, that's the most likely.

Here's my md5 file.

Changed 7 years ago by misterhands

Attachment: KQV.md5 added

comment:4 Changed 7 years ago by digitall

misterhands: Thank you for providing the request information. I have also asked for the same information for the Polish variant via bug #2725722, to be attached here, so when that occurs, we should have sufficient information to amend the detection entries to prevent this detection collision. If we receive no response on this, we will look at amending or disabling the Polish detection entry anyway, but this could break Polish detection.

comment:5 Changed 7 years ago by sev-

Raising priority. This is a release-critical bug.

comment:6 Changed 7 years ago by sev-

Priority: normalblocker

comment:7 Changed 7 years ago by digitall

Have checked in the engines/sci/detection_tables.h. This is not a case of duplicate MD5sums, but that the Polish entry is marked as dual language with English. The relevant entry is:
// King's Quest 5 - Polish DOS Floppy (supplied by jacek909 in bug report #2725722, includes english language?!)
// SCI interpreter version 1.000.060
{"kq5", "", {
{"", 0, "70010c20138541f89013bb5e1b30f16a", 7998},
{"resource.000", 0, "a591bd4b879fc832b8095c0b3befe9e2", 276398},
{"resource.001", 0, "c0f48d4a7ebeaa6aa074fc98d77423e9", 1018560},
{"resource.002", 0, "7f188a95acdb60bbe32a8379ba299393", 1307048},
{"resource.003", 0, "0860785af59518b94d54718dddcd6907", 1348500},
{"resource.004", 0, "c4745dd1e261c22daa6477961d08bf6c", 1239887},
{"resource.005", 0, "6556ff8e7c4d1acf6a78aea154daa76c", 1287869},
{"resource.006", 0, "da82e4beb744731d0a151f1d4922fafa", 1170456},
{"resource.007", 0, "431def14ca29cdb5e6a5e84d3f38f679", 1240176},

I think misterhands is indicating that this version is not dual language, but English only. Not sure if the Polish language version was supplied as Patch files on top of this base version?
Hopefully one of the SCI developers has the same version and can clarify.

comment:8 Changed 7 years ago by bluegr

Priority: blockernormal

comment:9 Changed 7 years ago by bluegr

So it seems that the Polish version is incomplete. I've added this version in the detection entries, but
we will need a better way of distinguishing the two versions properly.

misterhands: could you please provide a checksum of all of your game files?

Here's information on how to do this:

I'm lowering priority of this one, and I'm reopening the other bug report

comment:10 Changed 7 years ago by misterhands

thebluegr: well I did already as requested by tdhs, see the attached md5sums file.

comment:11 Changed 7 years ago by digitall

misterhands: The md5sums you did are for the full file, which allows us to be sure of your exact version, but our detector only calculates the md5sum checksum of the first <n> bytes of a file, so the values differ. The link explains how to manually get these "restricted" checksums:

In case you wonder, the reason we don't calculate the checksum over the entire file is that doing this for 100MB+ resource files would slow detection down to painfully slow degree.

comment:12 Changed 7 years ago by misterhands

thebluegr: ok but this wiki page does not specify the value of <n> for SCI...
should I assume it's 5000 bytes like most engines ?

comment:13 Changed 7 years ago by digitall

Yes, it is the default i.e. 5000 bytes. Will amend that wiki page.

comment:14 Changed 7 years ago by bluegr

Owner: set to bluegr
Resolution: fixed
Status: newclosed

comment:15 Changed 7 years ago by bluegr

Fixed in r2c5cf9f (master) and r3af8661 (branch 1.5), via MD5 checksums from the other bug report.


Note: See TracTickets for help on using tickets.