Opened 8 years ago

Closed 8 years ago

#5948 closed defect (fixed)

AGOS: Wrong sound effects during intro of Simon 2 (DOS)

Reported by: SF/simsaw Owned by: lordhoto
Priority: normal Component: Engine: AGOS
Keywords: Cc:
Game: Simon the Sorcerer 2

Description

During the intro of Simon 2 wrong sounds occur sometimes after the right one was played back. This is especially notable in the scene of Sordid's fortress when the wardrobe is sent to Simon. There may be other places where this is happening, but I haven't checked after the intro.

This should affect all DOS versions. I guess the bug may have something to do with the code changes concerning VOC streaming.

Ticket imported from: #3475610. Ticket imported from: bugs/5948.

Change History (8)

comment:1 by SF/simsaw, 8 years ago

Owner: set to Kirben

comment:2 by lordhoto, 8 years ago

When you talk about "sounds" do you mean voice overs or sound effects or both?

If you talk about voice overs, do you have subtitles enabled by chance?

comment:3 by SF/simsaw, 8 years ago

Summary: AGOS: Wrong sounds played during intro of Simon 2 (DOS)AGOS: Wrong sound effects during intro of Simon 2 (DOS)

comment:4 by SF/simsaw, 8 years ago

I mean sound effects only. Sorry that I was not clear enough. Changed the title now.

comment:5 by lordhoto, 8 years ago

This is definitly a problem since we added VOC streaming. It seems AGOS plays all ambient sounds and effects from the same file handle.

It also seems that for compressed files AGOS works around the fact that these always streamed from the disk. It simply does load all of the compressed files into memory.

It might make sense to rework the whole AGOS sound code and make it stream all sounds whenever possible.

comment:6 by lordhoto, 8 years ago

I did a quick implementation of my proposed fix over here: https://github.com/scummvm/scummvm/pull/172

comment:7 by lordhoto, 8 years ago

Owner: changed from Kirben to lordhoto
Resolution: fixed
Status: newclosed

comment:8 by lordhoto, 8 years ago

Should be fixed with c82a75df69aa5d8f36eae52deee508ef9a61e49e in master.

Note: See TracTickets for help on using tickets.