Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#5824 closed defect (fixed)

SCI: PQ1 - exits to console after loading game saved on map

Reported by: SF/pbossi Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: script Cc:
Game: Police Quest 1

Description

When loading a savegame created on the city map SCUMMVM exit to the console, displaying the following error: [VM] kDisplay[1b]: signature mismatch via method EndInter::changeState (room 500, script 500, localCall 0x3e8)!
Dos/English
Win7 64 bit Ultimate
Bug occured on 1.3.1 as well as on the Aug 10 2011 daily build
Tried non-patched version also
Attaching saved game for reference

Ticket imported from: #3389579. Ticket imported from: bugs/5824.

Attachments (6)

pq1sci.000 (31.6 KB) - added by SF/pbossi 8 years ago.
pq1save
pq1originalfiles.txt (1.9 KB) - added by SF/pbossi 8 years ago.
datafiles md5check
pq1sci.002 (28.5 KB) - added by SF/pbossi 8 years ago.
pq1 gog
pq1-pqcollection.txt (2.3 KB) - added by digitall 8 years ago.
Datafile MD5sum from PQ Collection
pq1gog..txt (3.5 KB) - added by SF/pbossi 8 years ago.
Pq1 Datafiles MD5sum ( GOG version)
pq1sci.001 (32.6 KB) - added by SF/pbossi 8 years ago.
Pq1 gog savegame "synched" version

Download all attachments as: .zip

Change History (24)

Changed 8 years ago by SF/pbossi

Attachment: pq1sci.000 added

pq1save

comment:1 Changed 8 years ago by wjp

Summary: Exits to console after loading game saved on mapSCI: PQ1: Exits to console after loading game saved on map

comment:2 Changed 8 years ago by SF/pbossi

Summary: SCI: PQ1: Exits to console after loading game saved on mapSCI PQ1 exits to console after loading game saved on map

comment:3 Changed 8 years ago by wjp

Summary: SCI PQ1 exits to console after loading game saved on mapSCI: PQ1: exits to console after loading game saved on map

comment:4 Changed 8 years ago by digitall

pbossi: Can you give the version of your PQ1SCI game?
This can be found in the game, using the Top Bar Settings Dialog. In the
box that appears with "GAME PAUSED", click the small button right of the
Question Mark at the bottom.
This then gives information on the game, starting on the first page with
the game version.
If you have trouble with this, the same version ID is given by the debug
console "version" command. The console is entered by CTRL-SHIFT-D.

It would also be useful to attach a text file of the MD5sums of your
datafiles, to help more accurate diagnose any corrupted files.
http://md5summer.org/ might be helpful here.

I can't load your savegame successfully on my PQ1SCI v2.0.0 here, though
it tries to load. This results in an infinite loop lockup of ScummVM when
loaded from Launcher or In Game.

comment:5 Changed 8 years ago by digitall

Summary: SCI: PQ1: exits to console after loading game saved on mapSCI: PQ1 - exits to console after loading game saved on map

comment:6 Changed 8 years ago by SF/pbossi

Added md5 txt for all my savegames including the one I sent. Everything seems ok

comment:7 Changed 8 years ago by digitall

pbossi: Thanks for your attention, but it is the md5 checksums of the _DATAFILES_ i.e. the game datafiles found on the original CD/floppies that you copied to HDD to run this with ScummVM, not the savegame files that are required.

See http://wiki.scummvm.org/index.php/Datafiles#SCI

comment:8 Changed 8 years ago by SF/pbossi

Sorry! I'm a Huge Noob! here's the txt. I've used this version since the
version I bought from Gog started with a message about fanmade scripts
possibly corrupting the game.

Changed 8 years ago by SF/pbossi

Attachment: pq1originalfiles.txt added

datafiles md5check

comment:9 Changed 8 years ago by digitall

Ah. You have a very early v1.0 version of PQ1 there.

I would suggest though avoiding this v1.0 version and going back to the
GOG patched version.

I suspect the conflicting patch is the NRS (third party) patch indicated
at http://www.sierrahelp.com/Patches-Updates/Patches-Updates-Games/PoliceQuestUpdates.html

Since ScummVM deals with these type of timer issues by dynamic patching
within the SCI engine, we need to work from an "official" base and any
variation triggers warnings.

If you remove the 994.* and 999.* files from your GOG version, ScummVM
should work with this without warning.

comment:10 Changed 8 years ago by SF/pbossi

Roger that. will try it first thing in the morning

comment:11 Changed 8 years ago by SF/pbossi

Reverting to the GOG version did not solve this issue, but I found out why my savegames didn't work, Removing or adding script datafiles results in SCUMMVM mentioned above not being able to load. I tried removing the 999 files and the warning message was still present so I re-copied them into the datafiles folder. Attaching the Savegame I made with the GOG version. If that does not work either could you send me the exact content of your pq1 folder so I can "sync " my data with yours?

Changed 8 years ago by SF/pbossi

Attachment: pq1sci.002 added

pq1 gog

comment:12 Changed 8 years ago by digitall

Compatibility of savegames when you change datafiles is not easily possible
with the SCI engine, without the possibility of very odd bugs, so this is
disabled.

This is no different from the original interpreter.

No, still can't load that savegame.
Can you please attach MD5sums of your GOG version as well?

I said "If you remove the 994.* and 999.* files from your GOG version, ScummVM
should work with this without warning.", not just 999.*
These are the NRS patch.

I can't send you the contents of the PQ1 folder as this violates the project's Rule #0 amongst other points.
Don't ask again:
http://wiki.scummvm.org/index.php/Copyright_FAQ

I am attaching a MD5sum list instead of my datafiles, so you can compare with the GOG version.

Changed 8 years ago by digitall

Attachment: pq1-pqcollection.txt added

Datafile MD5sum from PQ Collection

comment:13 Changed 8 years ago by SF/pbossi

That's what I meant. :) A list of the content of the folder not the actual files! Now I'll remove every file you don't have in my folder in order for mine to match exactly with yours, so hypothetically my next savegame should finally be compatible with your version . I'm deeply sorry for your trouble. The next one I send you should work. Attaching GOG md5.

Changed 8 years ago by SF/pbossi

Attachment: pq1gog..txt added

Pq1 Datafiles MD5sum ( GOG version)

comment:14 Changed 8 years ago by SF/pbossi

Attaching hopefully working saved game. Fingers crossed.

Changed 8 years ago by SF/pbossi

Attachment: pq1sci.001 added

Pq1 gog savegame "synched" version

comment:15 Changed 8 years ago by digitall

pbossi: Thanks. The new attached savegame is loadable by my version and I confirm replication of the same bug.

This will require a SCI engine developer to look at the scripts for this screen to determine a fix/workaround for this script bug. This will take a little time, so please standby and be patient.

I should also note that loading on this screen was not possible in the original interpreter i.e. bug in the original scripts and has been previously reported as bug #3035821 "PQ1VGA: No map when loading a save while patrolling" which was closed as not possible to fix:
https://sourceforge.net/tracker/index.php?func=detail&aid=3035821&group_id=37116&atid=418820
This seems to have been improved, but it may require extensive patching to correct the scripts well enough to support stable loading in this screen.

comment:16 Changed 8 years ago by SF/pbossi

No worries. Take your time. Happy to help!

Tried running it with the original intepreter in dosbox. The game doesn't show the map for about 4-5 seconds but then it's restored on the screen and most importantly the game does not crash.

comment:17 Changed 8 years ago by bluegr

A script bug. Added two workarounds for it in r3774c38. Thanks for reporting!

comment:18 Changed 8 years ago by bluegr

Keywords: script added
Owner: set to bluegr
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.