SWORD25: Code analysis warnings
|Reported by:||Templier||Owned by:|
|Cc:||Game:||Broken Sword 2.5|
Here are the warnings I get when compiling the engine using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.
Note: I have silened most of the warnings in lua & art for now (most are NULL dereference warnings for malloc)
d:\sources\scummvm\scummvm\engines\sword25\util\lua\ldo.cpp(118): warning C4611: interaction between '_setjmp' and C++ object destruction is non-portable This is not an analysis warning. It might need to be disabled in the property file when generating the project files with create_msvc if deemed invalid
d:\sources\scummvm\scummvm\engines\sword25\kernel\log.cpp(124): warning C6053: Call to '_snprintf' might not zero-terminate string 'ExtFormat' d:\sources\scummvm\scummvm\engines\sword25\package\packagemanager.cpp(189): warning C6283: 'buffer' is allocated with array new , but deleted with scalar delete d:\sources\scummvm\scummvm\engines\sword25\gfx\graphicengine.cpp(229): warning C6011: Dereferencing NULL pointer 'fillRectPtr' d:\sources\scummvm\scummvm\engines\sword25\fmv\theora_decoder.cpp(248): warning C6011: Dereferencing NULL pointer 'value'
Note: If you want to try it yourself, you will need: - the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src) - the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch ) - Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)
Ticket imported from: #3090234. Ticket imported from: bugs/5458.