Opened 9 years ago

Closed 8 years ago

#5292 closed defect (fixed)

SCI: MOTHERGOOSE SCI1.1: Latest "Coin" doesn't display

Reported by: SF/kuroshiro Owned by: wjp
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game: Mixed-Up Mother Goose

Description

Mixed Up Mother Goose (Floppy/Dos/English)
ScummVM 1.2.0SVN 52290
Windows 7 x64

Whenever you solve one of the puzzles, a little coin appears in the bottom left. However, after leaving the screen, the most recent coin will vanish, only reappearing when you solve another one.

Ticket imported from: #3051136. Ticket imported from: bugs/5292.

Change History (12)

comment:1 Changed 9 years ago by SF/kuroshiro

Update: loading a game apparently fixes this, but then a different crash occurs. Posting seperately.

comment:2 Changed 9 years ago by m-kiewitz

Summary: MOTHERGOOSE: Latest "Coin" doesn't displayMOTHERGOOSE SCI1.1: Latest "Coin" doesn't display

comment:3 Changed 9 years ago by m-kiewitz

sadly this doesn't happen, when you restore a saved game. The coin will be there and will also stay in that case.

comment:4 Changed 9 years ago by SF/kuroshiro

Yes, as I said before restoring seems to fix it. However, if you start a new game and solve a puzzle it will still occur.

comment:5 Changed 9 years ago by SF/kuroshiro

I have narrowed this down a bit more after playing through the game again...

The error will happen when you start a new game, throughout the game, until you quit and reload. However, if you save the game *before* solving any puzzles and reload, then the glitch will still be present.

Finally, even if you have reloaded the game and "Fixed" the glitch, no matter what after you solve the final puzzle to beat the game, the last coin will vanish when you change rooms flying on the goose. Can't really provide a save game to show this as the game deletes saves after it ends (which I believe is proper behavior).

comment:6 Changed 8 years ago by bluegr

There were several changes regarding graphics in the latest unstable version. Could you test if this issue still occurs?

comment:7 Changed 8 years ago by bluegr

Actually, nvm, just tested it and this issue still occurs :(

comment:8 Changed 8 years ago by wjp

Still occurs with git 0360b4ac95e08d6350f63b0801557ebed9a90796 too.

The score is global 0x0f, by the way.

comment:9 Changed 8 years ago by wjp

Summary: MOTHERGOOSE SCI1.1: Latest "Coin" doesn't displaySCI: MOTHERGOOSE SCI1.1: Latest "Coin" doesn't display

comment:10 Changed 8 years ago by wjp

The responsible code is the following block in graphics/transitions.cpp:

if (picRect.bottom != _screen->getHeight()) {
// TODO: this is a workaround for lsl6 not showing menubar when playing
// There is some new code in the sierra sci in ShowPic that seems to do
// something similar to this
_screen->copyToScreen();
g_system->updateScreen();
}

Disasbling that fixes it. We should figure out which SCI versions need this code, if any.

comment:11 Changed 8 years ago by wjp

Fixed in 8e2f2e3730c27fd9ac6172eb8007fb362a198678.

comment:12 Changed 8 years ago by wjp

Owner: set to wjp
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.