Opened 17 years ago

Closed 15 years ago

Last modified 15 years ago

#514 closed defect (fixed)

DIG: Inventory icon stutters

Reported by: SF/jsaathof Owned by: fingolfin
Priority: low Component: Engine: SCUMM
Keywords: Cc:
Game: The Dig

Description

I noticed that when in the Nexus the inventory icon drags behind the movement, make the screen "stutter".

I have read about a problem with The Dig crashing when moving more than once around the Nexus. I haven't seen much crashes thoughout the game, however when the game crashed I noticed right before the crash that the inventory icon had disappeared.

Also the scrolling in the museum is strange. the background moves faster than the room itself.

I use Scummvm 0.2.2 CVS built on Oct 26 2002 on a Debian Linux system. English talkie version of The Dig.

Ticket imported from: #629417. Ticket imported from: bugs/514.

Change History (19)

comment:1 by SF/jsaathof, 17 years ago

I also found some locations wouldn't scroll at all. Changing rooms have fixed this problem but it isn't a good solution.

comment:2 by SF/logicdeluxe, 17 years ago

In the museum the background scrolls also faster with the original exe. I think this is intended that way. If not, it is a bug in the script.

comment:3 by fingolfin, 17 years ago

Summary: DIG: ScrollingDIG: Inventory icon stutters

comment:4 by fingolfin, 17 years ago

The nexus crash should be fixed. Inventory icon stil stutters, though.

comment:5 by fingolfin, 17 years ago

I have no clue how the inventory icon is draw... ender, do you know more?

comment:6 by fingolfin, 17 years ago

Owner: set to SF/ender

comment:7 by SF/ender, 17 years ago

I think, from memory, it's an actor. But I don't really know more than that.

comment:8 by SF/ender, 17 years ago

Owner: changed from SF/ender to fingolfin

comment:9 by fingolfin, 17 years ago

Hm, it seems as if the inventory icon is actor 2 (with y = 1078 and elev = 900 permanently it seems).

And it seems that its position is keyed to the position of Boston Low, rather than the bottom left of the visible display (I guess some script does that). Which explains the "stuttering" - as Boston steps, the inventory icon moves.

comment:10 by fingolfin, 17 years ago

Owner: fingolfin removed

comment:11 by SF/ender, 17 years ago

*nods*

The Dig contains Walkscripts which are supposed to execute when the actors move.. that do things like smooth out turning and make the walking animation look better by adjusting it to fix scaling (eg, walking up steps).

We have them commented out at the moment because they don't execute correctly... it doesn't seem to affect the gameplay... but my guess is that maybe the walkscript is also responsible for somehow smoothing out the linkage between Boston and the Inventory Icon?

comment:12 by fingolfin, 17 years ago

Script 75 steers actor 2 (the inventory icon). Script disasm attached

comment:13 by fingolfin, 17 years ago

The solution seems to be the following: * the script sets the inventory icon position based on the camera pos * the camera position is pixel precise * the actual scrolling is done in steps of 8 ("strips") * but the real Dig does smooth scrolling (pixel wise). Hence to solve this I think we need to implement smooth scrolling.

That's of course easier to said than done... but at least now know what's wrong :-)

It might even be possible to use it in older games, although I fear it could lead to strange bugs, so we might better not use it.

comment:14 by SF/madshi, 15 years ago

Perhaps you could add a global option to enable smooth scrolling for old games (default = disabled). Then people can test it for old games. You could later enable it by default for those games which are known to work with it without any problems.

comment:15 by fingolfin, 15 years ago

Priority: normallow

comment:16 by fingolfin, 15 years ago

This is cosmetical only, lowering priority.

comment:17 by eriktorbjorn, 15 years ago

Since the "smooth scrolling hack" has been enabled by default, perhaps this bug report could be closed?

comment:18 by fingolfin, 15 years ago

Smooth scrolling for Dig, FT, COMI are now in CVS and seem to work quite well...

Kind of a pity to close this bug just before it reaches its second birthday ;-)

comment:19 by fingolfin, 15 years ago

Owner: set to fingolfin
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.