Opened 10 years ago

Closed 10 years ago

#4885 closed defect (fixed)

FOTAQ Amiga: crashes reporting assertion failure

Reported by: SF/zaurak Owned by: fingolfin
Priority: normal Component: Engine: Queen
Keywords: Cc:
Game: Flight of the Amazon Queen

Description

ScummVM 1.1.148874 (Apr 30 2010 11:41:34)
Flight of the Amazon Queen, English Amiga version (floppy)
Windows XP

Regards,
Jan

Ticket imported from: #3001110. Ticket imported from: bugs/4885.

Attachments (1)

queen.s09 (12.1 KB ) - added by SF/zaurak 10 years ago.

Download all attachments as: .zip

Change History (7)

by SF/zaurak, 10 years ago

Attachment: queen.s09 added

comment:1 by SF/zaurak, 10 years ago

Forgot the report::

ScummVM quits running FOTAQ (Amiga) reporting:

"Assertion failed: ch.offset.int_off < ch.length, file sound/mods/paula.cpp, line 137

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information."

Load the savegame and walk to the path on the right. ScummVM will quit then reporting above message.

Alternately, start FOTAQ Amiga and let the intro run for approx. one minute. ScummVM will quite as well showing the same message.

comment:2 by SF/zaurak, 10 years ago

The bug was introduced with ScummVM 1.1.0. The bug is not present using ScummVM 1.0.0 and older versions.

Regards,
Jan

comment:3 by fuzzie, 10 years ago

setupPaulaChannel is passing a offset which is beyond the length of the buffer; changing paula.h:163 to "ch.offset = Offset(offset % ch.length);" fixes it for me, but I have no idea if that's the correct fix or whether the actual bug lies elsewhere.

comment:4 by fuzzie, 10 years ago

http://ccdevnet.org/~fuzzie/0001-rjp1-calculate-sample-length-correctly.txt seems more likely to be the correct fix. I'll put it on the patch tracker once I'm a bit more sure I'm not crazy, since it seems someone would've noticed.

comment:5 by fingolfin, 10 years ago

Owner: set to fingolfin
Resolution: fixed
Status: newclosed
Summary: FOTAQ Amiga crashes reporting "Assertion failed"FOTAQ Amiga: crashes reporting assertion failure

comment:6 by fingolfin, 10 years ago

Fixed by patch #r49210. Thanks fuzzie!

Note: See TracTickets for help on using tickets.