Opened 14 years ago
Closed 14 years ago
#4747 closed defect (fixed)
IHNM: Small problem detecting German version
| Reported by: | SF/leonardoboshell | Owned by: | sev- |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SAGA |
| Version: | Keywords: | detection | |
| Cc: | Game: | I Have No Mouth |
Description
Hello,
I know this is just a small issue, but when the german version of IHNM is being added, the detector can't decide if it's the German or the French version, so it displays both in a list. Ideally, the German version should be detected directly.
Taking a look at the detection tables, I see that it's because these two versions (German and French) are being detected using the same files, which have the same md5sum's; however, the entries for the German version include the size of the scream.res file, but the entries for the French version don't. Incidentally, this means that if the french version is being added, it gets recognised correctly (it sees that it can't be the German version because of the file size), but the problem exists for the German version.
A solution would be to add the size of scream.res for the French version in the detection tables. I grabbed a copy of the french version just to test this out, and with that I made this patch which fixes the problem.
Thanks.
Ticket imported from: #2929619. Ticket imported from: bugs/4747.
Attachments (1)
Change History (7)
by , 14 years ago
| Attachment: | scummvm-svn-ihnm_detection.patch added |
|---|
comment:1 by , 14 years ago
| Summary: | Small problem detecting German version → IHNM: Small problem detecting German version |
|---|
comment:2 by , 14 years ago
| Priority: | normal → low |
|---|
comment:4 by , 14 years ago
| Priority: | low → normal |
|---|
comment:6 by , 14 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Patch to the detection entries for the french IHNM