Opened 10 years ago

Closed 10 years ago

#4747 closed defect (fixed)

IHNM: Small problem detecting German version

Reported by: SF/leonardoboshell Owned by: sev-
Priority: normal Component: Engine: SAGA
Keywords: detection Cc:
Game: I Have No Mouth

Description

Hello,

I know this is just a small issue, but when the german version of IHNM is being added, the detector can't decide if it's the German or the French version, so it displays both in a list. Ideally, the German version should be detected directly.

Taking a look at the detection tables, I see that it's because these two versions (German and French) are being detected using the same files, which have the same md5sum's; however, the entries for the German version include the size of the scream.res file, but the entries for the French version don't. Incidentally, this means that if the french version is being added, it gets recognised correctly (it sees that it can't be the German version because of the file size), but the problem exists for the German version.

A solution would be to add the size of scream.res for the French version in the detection tables. I grabbed a copy of the french version just to test this out, and with that I made this patch which fixes the problem.

Thanks.

Ticket imported from: #2929619. Ticket imported from: bugs/4747.

Attachments (1)

scummvm-svn-ihnm_detection.patch (819 bytes ) - added by SF/leonardoboshell 10 years ago.
Patch to the detection entries for the french IHNM

Download all attachments as: .zip

Change History (7)

by SF/leonardoboshell, 10 years ago

Patch to the detection entries for the french IHNM

comment:1 by SF/leonardoboshell, 10 years ago

Summary: Small problem detecting German versionIHNM: Small problem detecting German version

comment:2 by SF/leonardoboshell, 10 years ago

Priority: normallow

comment:3 by sev-, 10 years ago

Please do not alter piority.

comment:4 by sev-, 10 years ago

Priority: lownormal

comment:5 by sev-, 10 years ago

Thanks, I updated the detection tables.

comment:6 by sev-, 10 years ago

Owner: set to sev-
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.