Opened 10 years ago

Closed 10 years ago

#4406 closed defect (fixed)

SAM: crash at the end of credits sequence

Reported by: criezy Owned by: wjp
Priority: blocker Component: Engine: SCUMM
Keywords: Cc:
Game: Sam and Max


Sam & Max crashes at the end of the credits sequence (when the game really starts). This is the french macintosh CD version.
I get the debugger with the following error: ERROR: (7:66:0x17): Cannot read resource!

This looked a lot like a corrupted data file, therefore I recopied the file twice from the original CD with the same result. Also the games works fine with ScummVM 0.13.1 with the same data file and the same settings.

Ticket imported from: #2820957. Ticket imported from: bugs/4406.

Change History (17)

comment:1 Changed 10 years ago by criezy

I forgot to say that I am using version 1.0.0svn42398 (from July 12) on MacOS X 10.4 (intel).

Also I just started the game with 0.13.1 (again) and saved right at the beginning (after the credit sequence). If I load that save game in 1.0.0svn I can then play the game.

comment:2 Changed 10 years ago by lordhoto

It would be nice if you could attach both saves to this tracker item.

comment:3 Changed 10 years ago by lordhoto

I think the cause for this is that SCUMM seems still to use "ioFailed". For a ReadStream we changed the implementation for that from "return err();" in 0.13.0 to "return (eos() || err());" in current trunk. I guess this resource it's trying to load is directly the last resource, resulting in an eos being set, thus making SCUMM think it could not read the resource properly.

comment:4 Changed 10 years ago by criezy

Actually I have only one save (made with ScummVM 0.13.1) just after the crash occurs. I don't have a save before the crash because it occurs right at the beginning. I start the game in ScummVM, press Esc three times, and it crashes (it also crashes if I don't press Esc and looks at the intro sequence and credits).

I also just tried to use extract_scumm_mac which works fine and I get five files. If I point ScummVM 1.0.0svn to these files it doesn't crash. Therefore the problem seems to occur only when playing with the original "Sam & Max Data" file.

comment:5 Changed 10 years ago by lordhoto

Yeah sorry that was my fault, I thought of the credits at the end of the game, I must have missed the "(when the game really starts)" :-).

comment:6 Changed 10 years ago by eriktorbjorn

My English Mac version crashes right at the start, after loading Room resource 94, but appears to work in 0.13.1. As Lordhoto says, it seems to think that eos() means an error occurred, which seems odd to me because the read() function claims it read as much data as it asked for.

I haven't played through the game in 0.13.1, so of course I might have messed up in copying the files from the CD. My "Sam & Max Data" file is 199,195,304 bytes, and its MD5 sum is e84d3a41b3015de79344f2c507639eed.

comment:7 Changed 10 years ago by eriktorbjorn

The problem appears to have been introduced in r40725: "COMMON: Removed Stream::ioFailed() and clearIOFailed(), as they are deprecated; however, retined ioFailed() in SeekableReadStream and File for now (so for now this mainly affects WriteStream subclasses)"

comment:8 Changed 10 years ago by fingolfin

Owner: set to fingolfin
Priority: normalhigh
Summary: Sam & Max crash at the end of credits sequenceSAM: crash at the end of credits sequence

comment:9 Changed 10 years ago by fingolfin

The problem is probably that ScummFile has not been correctly converted to the new Stream semantics. In particular it sets its _myIoFailed flag to "true" if one attempts to read beyond the end of the file.This causes all kinds of confusion.

The issue is probably a bit more complex than that, but I don't have time to look into this now. If nobody beats me to it, I'll try to fix it tonight. And get rid of all ioFailed() uses in SCUMM. Ideally, also in all other engines, but that might cause more regressions, so we should discuss it on -devel.

comment:10 Changed 10 years ago by sev-

Priority: highblocker

comment:11 Changed 10 years ago by wjp

It looks like the problem is that ScummFile::eos() still defines end-of-stream for subfiles as 'pos >= size', and that the 'new'ioFailed() now returns 'eos() || err()', so it flags reading up to the end of the file as an ioFailed.

I just committed a patch that made the end-of-stream behaviour consistent, and double-checked that all uses of ioFailed and eos() in scummvm expect the new behaviour. (r42632)

Thierry, could you check if that indeed fixes the problem with Sam & Max?

comment:12 Changed 10 years ago by eriktorbjorn

I've only tried the intro, but since it used to crash immediately for me, it definitely works a lot better now. I'd be interested to hear from criezy thogh, since he reported the bug and his problems were different from mine.

comment:13 Changed 10 years ago by wjp

Owner: changed from fingolfin to wjp
Resolution: fixed
Status: newpending

comment:14 Changed 10 years ago by criezy

Status: pendingnew

comment:15 Changed 10 years ago by criezy

I can confirm the problem seems to be fixed with r42856 (I didn't play very far but at least it doesn't crash at the end of the intro sequence now).

comment:16 Changed 10 years ago by wjp

Status: newclosed

comment:17 Changed 10 years ago by wjp

That's good to hear. Thanks for the report and testing.

Note: See TracTickets for help on using tickets.