Opened 12 years ago

Closed 12 years ago

Last modified 22 months ago

#4107 closed defect (fixed)

ALL: Graphic is wrong with hq2x/hq3x in fullscreen

Reported by: criezy Owned by: fingolfin
Priority: normal Component: Graphics: Scalers
Keywords: Cc:
Game:

Description

The two attached screenshots show the issue with Indy FOA: the colours are completely wrong. The problem occurs with all games I have, only in full screen mode (i.e. not in windowed mode), and only with HQ2x and HQ3x scalers (I didn't have the courage to test all of them actually, but I tested Super2xSAI, SuperEagle, AdvMAME2x, AdvMAME3x, HQ2x, HQ3x, TV2x and DotMatrix).

The problem occurs when calling configure without any flags before compiling. If I call configure with --disable-nasm the problem disappears completely with all scalers (all the ones I tested anyway, see list below) and all games. This is with code from trunck (0.14.0svn) on January 23 2009 (rev 36023) but I had this problem before.

Some more info: Intel iMac from early 2006 (the only one with a core duo I think as the next generation had a core 2 duo). MacOS X 10.4 with what I think is the latest compatible Developers Kit (2.5, this is a fresh installation as I had even more issue with the previous version).

SDL 1.2.13 (but I had the same issue with 1.2.11).

nasm -v: NASM version 0.98.40 (Apple Computer, Inc. build 11) compiled on Apr 20 2007

scummvm -v: ScummVM 0.14.0svn (Jan 23 2009 19:58:56) Features compiled in: Vorbis FLAC MP3 zLib MPEG2

Ticket imported from: #2531679. Ticket imported from: bugs/4107.

Attachments (2)

scummvm00000.png (220.6 KB ) - added by criezy 12 years ago.
screenshot showing the issue
scummvm00001.png (275.0 KB ) - added by criezy 12 years ago.
second screenshot

Download all attachments as: .zip

Change History (8)

by criezy, 12 years ago

Attachment: scummvm00000.png added

screenshot showing the issue

by criezy, 12 years ago

Attachment: scummvm00001.png added

second screenshot

comment:1 by criezy, 12 years ago

And some more information:

The problem do not occur only with my builds but also with the Universal Binary build provided by fingolfin on the forum two days ago (except if I use the option to open it with Roseta, i.e. using the PPC code, in which case it works fine).

In the same forum thread, somebody mentioned that there is something about this in the wiki: "Also note that you should run ./configure with --disable-nasm. The x86 assembly versions of the HQ2x and HQ3x scalers don't work properly on Mac OS X". It seems this is exactly the problem I am having and that this is therefore still valid, although it seems to work for some people with nasm.

comment:2 by fingolfin, 12 years ago

Owner: set to fingolfin
Summary: Graphic is wrong with hq2x/hq3x in fullscreenALL: Graphic is wrong with hq2x/hq3x in fullscreen

comment:3 by fingolfin, 12 years ago

I can confirm the bug. It is not related to a problem with NASM -- it's a bug (missing feature) in the asm version of hq2x, which is only written with 565 mode in mind. We adapted it to also work in 555 mode, but overlooked at least one spot (the zerolowbits constant, if you want to know).

In fact, this asm version of hq2x / hq3x (it's the original one) is missing quit some optimization opportunities, too. I wonder whether the end product is actually faster than our optimized C++ hq2x code... gotta set up a performance test, I guess :).

comment:4 by fingolfin, 12 years ago

Resolution: fixed
Status: newclosed

comment:5 by fingolfin, 12 years ago

Fixed in trunk (but not in the 0.13 branch).

comment:6 by digitall, 22 months ago

Component: --Unset--Graphics: Scalers
Note: See TracTickets for help on using tickets.