Opened 12 years ago

Closed 12 years ago

#3992 closed defect (fixed)

FREDDI1: Game does not start

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Freddi Fish 1


Latest SVN snapshot Swedish version of the game, but that probably doesn't matter.

Freddi Fish 1 no longer starts with the latest version of ScummVM. The debug console is currently out of order, but the important warnings/errors are probably these:

WARNING: FSNode::openForReading: FSNode does not exist! (0:1:0x3C): Cannot open file freddi.he3!

This appears to be because Win32ResExtractor::extractResource_() uses the FSNode class directly to open "freddi.he3", rather than providing a full path or using the normal file handling functions.

The file handling in ScummVM has evolved to the point where I no longer understand it, so I don't understand why it does this, but it may have been introduced in r34694. This commit made other changes as well, but I don't know where that part of the code is used so I don't know if it introduced any other regressions.

Ticket imported from: #2162342. Ticket imported from: bugs/3992.

Change History (3)

comment:1 by fingolfin, 12 years ago

I commited a fix in rev 34793, but can't test it -- please tell me if it helped.

I'll write a mail to scummvm-devel, talking a bit about the new file handling approach (which actually isn't that complicated, I think... but well.. :).

comment:2 by eriktorbjorn, 12 years ago

Yes, the game starts now. Thanks! And thanks for the explanation of the file handling on the mailing list. I've only given it a quick read-through, but I'll be sure to read it more carefully later.

I still don't know if the other FSNode-related change that was made at the same time (in ScummEngine_v60he::o60_openFile(), I believe) caused any regressions, though. I don't know where that's used.

comment:3 by fingolfin, 12 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.