Opened 11 years ago

Closed 11 years ago

Last modified 6 years ago

#3830 closed defect

INDY3: Non-Looping Sound Effects

Reported by: SF/mthreepwood Owned by:
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Indiana Jones 3

Description

Indy3 VGA DOS English, Windows XP 0.12.0pre.

Certain sound effects do not loop. They play once, and then cut out. For instance, the waterfall underground does not loop nor does the machine gun that is fired when you free Henry Sr. However, some sound effects do loop (such the water dripping before you pull out the cork).

Saved game attached by the waterfall. s63 is after the sound, s64 is before.

Ticket imported from: #2027877. Ticket imported from: bugs/3830.

Attachments (2)

indy3.s63 (16.4 KB ) - added by SF/mthreepwood 11 years ago.
Saved Game (Waterfall, no sound)
indy3.s64 (15.5 KB ) - added by SF/mthreepwood 11 years ago.
Saved Game (Use whip with hook)

Download all attachments as: .zip

Change History (15)

by SF/mthreepwood, 11 years ago

Attachment: indy3.s63 added

Saved Game (Waterfall, no sound)

by SF/mthreepwood, 11 years ago

Attachment: indy3.s64 added

Saved Game (Use whip with hook)

comment:1 by SF/mthreepwood, 11 years ago

File Added: indy3.s64

comment:2 by eriktorbjorn, 11 years ago

I guess there's some feature missing in the handling of the Indy 3 Adlib sound effects. Using the PC speaker or PCjr music drivers works, though this looks like one of those cases where ScummVM doesn't like using another music driver than the one it started with. (There's a bug report about that somewhere; I forget the number.)

comment:3 by eriktorbjorn, 11 years ago

I forgot to say... the dripping sound doesn't actually loop, as far as I can tell. It appears to be a series of short sound effects that are played over and over.

comment:4 by SF/mthreepwood, 11 years ago

The dripping sound isn't supposed to loop. But, if you use the whip on the hook, the sound of the water coming out of the whole is supposed to loop.

comment:5 by eriktorbjorn, 11 years ago

Surely, the dripping noises are supposed to play for as long as the water is dripping? But it's not looping in the sense that the rushing water should do (but doesn't currently, if you're using Adlib).

The bug report made it sound like looping worked sometimes, and sometimes not. I was trying to clarify the differences between the two cases I've listened to.

comment:6 by SF/mthreepwood, 11 years ago

Yes, you're right. I'm sorry, I've confused myself.

comment:7 by sev-, 11 years ago

So, is this bugreport valid?

comment:8 by eriktorbjorn, 11 years ago

Probably. The sound of rushing water loops if you use the PC Speaker / PCjr sound driver, but not if you use the Adlib driver. I assume it should loop with the Adlib driver.

(The discussion about the dripping water sound effect was just a clarification that there are sound effects that appear to be looping, but which are actually just a collection of short sound effects played over and over.)

comment:9 by SF/mthreepwood, 11 years ago

Hmmm... I just noticed this was already mentioned on the TODO page (third from bottom):

http://wiki.scummvm.org/index.php/SCUMM/TODO#General_TODO

comment:10 by sev-, 11 years ago

Status: newclosed

comment:11 by sev-, 11 years ago

This bugreport has been moved to Wiki to relevant Engine/TODO page. When the bug will be resolved, an appropriate message will be posted here and the bugreport link removed from Wiki

comment:12 by lordhoto, 8 years ago

Small update: I found out we handle command 0x80 in the sfx resources incorrectly, the original used it to loop a single channel, while we interpret it as stop. I added a FIXME to our code for now, so it won't be forgotten.

comment:13 by lordhoto, 6 years ago

The missing loop command is actually *not* the cause of this issue. The original allowed an infinite note time. This is used in this case.

Note: See TracTickets for help on using tickets.