Opened 13 years ago

Closed 13 years ago

#3053 closed defect

BASS: wrong music slider behavior

Reported by: salty-horse Owned by: lavosspawn
Priority: normal Component: Engine: Sky
Keywords: Cc:
Game: Beneath a Steel Sky

Description

Using latest svn.

When dragging the music slider to the lowest bar, music can still be heard.
Since the music muting button is only available in the floppy version, this means that one cannot mute the music in the CD version.

Also, the music_volume config key is initialized on startup, but is not updated when the slider changes.

Ticket imported from: #1657466. Ticket imported from: bugs/3053.

Attachments (2)

sky-adlib.diff (2.5 KB ) - added by eriktorbjorn 13 years ago.
Patch against current SVN
sky-adlib2.diff (2.9 KB ) - added by eriktorbjorn 13 years ago.
Updated patch against even more current SVN

Download all attachments as: .zip

Change History (8)

comment:1 by eriktorbjorn, 13 years ago

It doesn't seem to be the control panel that's at error. Moving the slider to its lowest setting causes _skyMusic->setVolume(0) to be called. But if I use the Adlib music driver, that apparently doesn't silence the music...

by eriktorbjorn, 13 years ago

Attachment: sky-adlib.diff added

Patch against current SVN

comment:2 by eriktorbjorn, 13 years ago

Here's a possible fix for the music volume. It works by setting the music volume in the mixer instead. It still doesn't update the volume setting in the ScummVM configuration file, though.
File Added: sky-adlib.diff

comment:3 by eriktorbjorn, 13 years ago

Owner: set to lavosspawn

by eriktorbjorn, 13 years ago

Attachment: sky-adlib2.diff added

Updated patch against even more current SVN

comment:4 by eriktorbjorn, 13 years ago

Of course, that last bit is easy to add... Updated patch.
File Added: sky-adlib2.diff

comment:5 by eriktorbjorn, 13 years ago

As noted in another (now closed) bug report, the music slider also seems to be broken for normal MIDI if there's percussion, e.g. the factory music.

comment:6 by lavosspawn, 13 years ago

Status: newclosed
Note: See TracTickets for help on using tickets.