Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#3015 closed defect

COMI: cracks in music (only mp3?)

Reported by: SF/beerdeer Owned by:
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 3

Description

version: english
build: daily jan 22, w32

I got cracks in the music, at least when its compressed to MP3. This bug is not always present, but nearly (see save state).
Even if its not only happening on fading it could be similar with #1635361.

And no, setting the sdl audiodriver to waveout does not help ;-)

thx for your work

Ticket imported from: #1643950. Ticket imported from: bugs/3015.

Attachments (1)

comi.s01 (85.0 KB ) - added by SF/beerdeer 13 years ago.
music (mp3?) bug

Download all attachments as: .zip

Change History (12)

by SF/beerdeer, 13 years ago

Attachment: comi.s01 added

music (mp3?) bug

comment:1 by fingolfin, 13 years ago

What version of the tools did you use?
What version of lame?
Did you try encoding the files again?
And on what kind system are you working?

comment:2 by SF/beerdeer, 13 years ago

I guess I used the tools bundled with scummvm 0.8x
Lame version 3.96, but the files seem to be ok, it doesn't crack when i play them under windows
I did not try to encode them again since there was no error printing during encoding process
Windows xp with sp2 installed, can not try it under linux right now

By the way, I've ran the tools without any params

comment:3 by fingolfin, 13 years ago

"it doesn't crack when i play them under windows" -- I am confused, where are you playing them then? From your report I had the impression you were experiencing the problem under Windows ?!?

comment:4 by SF/beerdeer, 13 years ago

Sorry, I meant the compressed files don't have cracks when I play them in an audio player, at least the one I can access (not in a container file).

I've played the game for a while now and it seems that the problem is occuring less times than I thought. Even if there was no error printing during encoding process I'll try it again, gimme some days.

comment:5 by SF/beerdeer, 13 years ago

Here's the result...
Not Compressed: No cracks
Vorbis compressed: No cracks
MP3 compressed: Cracks!

This time I used Lame 3.97 and the ScummVM tools bundled with build "Jan 22". No params were used.

Phew, that were 2 hours of work :-(
How come the vorbis files are larger than the mp3? I thought vorbis has got the better compression?

comment:6 by fingolfin, 13 years ago

Neither Ogg Vorbis nor MP3 have "better compression" per se. Just think about it for a sec: You can select a bitrate -- two MP3s of the same song can have very different sizes if one is encoded at 64kbit/s and the other at 192kbit/s. Other options affect this, further. So, asking which format "uses less space" is not quite accurate as such (as for both, you can choose this!). The "correct" question would be: "Which format will produce higher quality results for a given fixed bitrate, used by both codecs during the comparision".

So in this case, it's probably just that our tools use a higher default bitrate for Ogg Vorbis than for MP3 (which in turn is likely caused by different default bitrate settings in the relevant encoders).

As for the cracks: Still quite odd. All I can say at this point is that it works fine for me, and apparently for many other people, too. So right now I have no good idea what might be causing your troubles :-/.

comment:7 by fingolfin, 13 years ago

I am still confused by your statement, BeerDeer. How exactly are you able to play those files in an audio player? Given that the COMI datafiles (and their compressed variants) are in a proprietary file format?

Maybe you have some ScummVM supported game which makes use of audio tracks. If so, do you get cracks there, too? Testing with them would be easier, since these for these games we use straight .mp3/.flac/.ogg files.

comment:8 by fingolfin, 13 years ago

This tracker item is pending response by the submitter; we
cannot continue processing it before that happens. As a
consequence, its status has been set to "Pending". It will
automatically revert to "Open" once a new comment is made to
this item. If no response is made within 14 days, it will
automatically be closed.

Thank you.

comment:9 by fingolfin, 13 years ago

Status: newpending

comment:10 by SF/sf-robot, 13 years ago

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

comment:11 by SF/sf-robot, 13 years ago

Status: pendingclosed
Note: See TracTickets for help on using tickets.