Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#2899 closed defect (fixed)

Logical and should probably be bitwise and

Reported by: SF/matwad Owned by: DrMcCoy
Priority: normal Component: Engine: Gob
Keywords: Cc:
Game: Gobliiins

Description

Stumbled upon this while fiddling around with google code search:

http://www.google.com/codesearch?hl=en&lr=&q=scummvm+%22%26%26+0x%22&btnG=Search

engines/gob/mult_v2.cpp:1352 staticCount = (_multData2->staticCount + 1) && 0x7F; Should probably be: staticCount = (_multData2->staticCount + 1) & 0x7F;

Ticket imported from: #1593768. Ticket imported from: bugs/2899.

Change History (3)

comment:1 by DrMcCoy, 14 years ago

Resolution: fixed
Status: newclosed

comment:2 by DrMcCoy, 14 years ago

Yes, it should be a bitwise and, thanks for finding! :)

comment:3 by sev-, 14 years ago

Component: --Unset--Engine: Gob
Game: Gobliiins
Owner: set to DrMcCoy
Note: See TracTickets for help on using tickets.