Opened 13 years ago

Closed 13 years ago

Last modified 10 months ago

#2632 closed defect (fixed)

GUI: Default graphics mode not committing

Reported by: SF/scummman Owned by: sev-
Priority: high Component: GUI
Keywords: Cc:
Game:

Description

Once a graphics mode is selected, the user cannot
switch back to <default>. While the option is still
selectable in the menu, it does not commit.

Ticket imported from: #1496582. Ticket imported from: bugs/2632.

Change History (9)

comment:1 Changed 13 years ago by SF/scummman

Summary: Default graphics mode not committingGUI: Default graphics mode not committing

comment:2 Changed 13 years ago by SF/scummman

The same seems to be true for language selection.

comment:3 Changed 13 years ago by sev-

Raising priority. This is a release-critical bug.

comment:4 Changed 13 years ago by sev-

Priority: normalhigh

comment:5 Changed 13 years ago by sev-

Owner: set to sev-

comment:6 Changed 13 years ago by wjp

It looks like the

if ((int32)_gfxPopUp->getSelectedTag() >= 0) {

in OptionsDialog::close() needs an 'else' that
deletes/resets the gfx_mode key.

comment:7 Changed 13 years ago by sev-

Resolution: fixed
Status: newclosed

comment:8 Changed 13 years ago by sev-

Yes, that was the reason. Flawed logic. Fixed in SVN.

comment:9 Changed 10 months ago by digitall

Component: GUI
Note: See TracTickets for help on using tickets.