Opened 15 years ago

Closed 15 years ago

Last modified 3 years ago

#2563 closed defect (fixed)

SCUMM: HE Game variants broken

Reported by: Kirben Owned by: fingolfin
Priority: blocker Component: Engine: SCUMM
Version: Keywords:
Cc: Game:

Description

ScummVM 0.9.0svn (Apr 14 2006 11:43:23) Compiled with GCC 3.4.5 under mingw. Running on Windows XP Home Edition.

All HE71+ games, that use the generic HE variants currently fail under ScummVM, since revision 21768 of SVN. The default game is always choosen, instead of the HE generic variant.

The problem occrs when computing the precise game settings using 'gameVariantsTable'. The 'g->variant == 0' check, causes the default game to always be choosen in these cases.

If I change the current check of: if (g->variant == 0 || !scumm_stricmp(elem->variant, g- >variant)) to if (g->variant != 0 && !scumm_stricmp(elem->variant, g- >variant))

The HE games using generic HE variants work fine again, but that excludes any games without multiple variants.

Ticket imported from: #1470197. Ticket imported from: bugs/2563.

Change History (4)

comment:1 by fingolfin, 15 years ago

It should be possible to fix this by changing the variant of the base entries (those which list the explicit gameid) from 0 to "".

I can't really test that, though, since I have no suitable HE games.

comment:2 by Kirben, 15 years ago

Thanks, HE games using generic HE variants work fine again now.

comment:3 by Kirben, 15 years ago

Resolution: fixed
Status: newclosed

comment:4 by digitall, 3 years ago

Component: --Unset--Engine: SCUMM
Note: See TracTickets for help on using tickets.