Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#2336 closed defect (fixed)

GOB1: Crash when skipping intro

Reported by: bluegr Owned by: wjp
Priority: normal Component: Engine: Gob
Version: Keywords:
Cc: Game: Gobliiins

Description

ScummVM 0.8.0 (Oct 29 2005 12:07:20) - Win32

Gobliiins 1 Floppy English

Sometimes, when skipping the intro of Gobliiins 1 too quickly, ScummVM crashes (difficult to reproduce). The crash seems to happen when esc is pressed just before the first sound is heard (the guy on the bottom left drinking).

Ticket imported from: #1348254. Ticket imported from: bugs/2336.

Change History (6)

comment:1 by bluegr, 18 years ago

Priority: normallow
Summary: Crash when skipping introGOB1: Crash when skipping intro

comment:2 by SF/amirdekel, 18 years ago

I have an opposite version of this bug: Here gobliiins doesn't crash only when I DO skip the intro before the first sound is heard... so it's kind of an anti-bug :-)

comment:3 by Kirben, 18 years ago

I can reproduce the problem with the demo version, if I press ESC exactly when the goiblin with the banjo is talking, during the introduction.

A back trace from gdb: 0x0075525c in LinearMemoryStream<false, false, false, false>::readBuffer ( this=0x1b39f40, buffer=0x2c8eb5c, numSamples=512) at sound/audiostream.cpp:152 152 *buffer++ = READ_ENDIAN_SAMPLE(is16Bit, isUnsigned, _ptr, isLE); (gdb) bt #0 0x0075525c in LinearMemoryStream<false, false, false, false>::readBuffer ( this=0x1b39f40, buffer=0x2c8eb5c, numSamples=512) at sound/audiostream.cpp:152 #1 0x0075e6c9 in Audio::LinearRateConverter<false, false>::flow ( this=0x2c8eb58, input=@0x1b39f40, obuf=0x1c684a0, osamp=2048, vol_l=192, vol_r=192) at sound/rate.cpp:148 #2 0x006a3264 in Audio::Channel::mix (this=0x1b39f78, data=0x1c684a0, len=2048) at sound/mixer.cpp:483 #3 0x006a2343 in Audio::Mixer::mix (this=0x1a91d28, buf=0x1c684a0, len=2048) at sound/mixer.cpp:255 #4 0x006a2406 in Audio::Mixer::mixCallback (s=0x1a91d28, samples=0x1c684a0 "À\036À\036V\031V\031í\023í\023\205 \016\205\016\033\t\033 \t²\003²\003JþJþáøáøxóxó\017î\017îÓéÓé\037ç\037çjäjädâdâ", len=8192) at sound/mixer.cpp:265 #5 0x10001430 in SDL_GetAppState () from C:\msys\1.0 \local\bin\SDL.dll

comment:4 by Kirben, 18 years ago

Priority: lownormal

comment:5 by wjp, 18 years ago

This should be fixed now. It had deleted the sample data without actually stopping the sample.

comment:6 by wjp, 18 years ago

Owner: set to wjp
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.