Opened 14 years ago

Closed 12 years ago

Last modified 12 years ago

#2315 closed defect (fixed)

BS2: Strange colour in final cutscene

Reported by: eriktorbjorn Owned by: sev-
Priority: low Component: Engine: Sword2
Keywords: Cc:
Game: Broken Sword 2

Description

There is one brief part of the final BS2 cutscene where
one colour looks wrong. Does anyone know if the problem
is with the source material, the encoding or the decoding?

Look at the hair colour of the attached screenshot.

Ticket imported from: #1342595. Ticket imported from: bugs/2315.

Attachments (1)

bs2end.jpg (29.0 KB) - added by eriktorbjorn 14 years ago.
Screenshot from final cutscene

Download all attachments as: .zip

Change History (21)

Changed 14 years ago by eriktorbjorn

Attachment: bs2end.jpg added

Screenshot from final cutscene

comment:1 Changed 14 years ago by eriktorbjorn

I forgot to mention that this was observed with a recent
ScummVM CVS snapshot and the official re-encoded cutscenes.

comment:2 Changed 14 years ago by SF/ender

Owner: set to SF/ender

comment:3 Changed 14 years ago by SF/ender

To answer your question on IRC, yes I did prepare all the
cutscenes.

I'll have a look, although I wouldn't be that startled if it was
indeed an encoding problem.

comment:4 Changed 13 years ago by fingolfin

Status: newpending

comment:5 Changed 13 years ago by fingolfin

What is the status of this item?

comment:6 Changed 13 years ago by eriktorbjorn

Status: pendingnew

comment:7 Changed 13 years ago by eriktorbjorn

Unchanged, in the sense that it still happens. But I just
tried playing the cutscene using MPlayer instead, and the
colour is strange there too, so it appears to be a bug in
the cutscene file, not in the way ScummVM plays it.

I have not compared it to the original Smacker movie.

comment:8 Changed 13 years ago by fingolfin

So we need somebody to test the smacker file!

comment:9 Changed 13 years ago by SF/ender

Yeah, all that needs to be done is to play back the
original and check to see if the difference is there.

Sorry I've been so slack on this, my current install of
WINE hasn't been liking the smacker player and I've been
really lazy about finding a windows box :)

comment:10 Changed 13 years ago by fingolfin

Ender.... Any progress on this in the past half year *cough cough* ? :-)

comment:11 Changed 13 years ago by eriktorbjorn

I get the same glitch if I try to play the original SMK file
under Wine, but I don't know if it's a Wine problem, or a
problem with the SMK file itself.

The affected frames are finale0936.png through
finale0957.png. As a last resort, if we ever decide to
re-encode the cutscenes (perhaps as DXA) these frames can be
manually re-painted (hair and both eyebrows) using some
colour close to #c3c3c3. See finale0935.png for reference.

comment:12 Changed 13 years ago by SF/florob

It's not a wine problem, I just tried it under XP and the
wrong coloring is definitly in the original SMK file.

comment:13 Changed 13 years ago by eriktorbjorn

I have a set of corrected frames at
http://www.update.uu.se/~d91tan/ScummVM/finale.zip

comment:14 Changed 13 years ago by sev-

Owner: SF/ender deleted
Priority: normallow

comment:15 Changed 13 years ago by sev-

Unassigning ender and waiting until we decide what to do
with DXA player. See release status message.

comment:16 Changed 12 years ago by fingolfin

So, what are we doing with this? Either we will host DXA cutscenes, then we can include this modification as an improvement over the original. But then we should do it soon, not wait another year with it.

Or, we decide to close this as "won't fix". But considering we decided

comment:17 Changed 12 years ago by sev-

As I recall, we are going to remove MPEG2 cutscenes from our site in the next release and provide DXA instead of them, though the code for playing MPEG2 will stay at least for several versions more. Once that is done, i.e. the files uploaded, this could be closed. As of the glitch, eriktorbjorn provided pack of fixed cutscene frames, which could be used as a replacement.

Or if you think that we can upload DXA cutscenes now, that could be done. Assign this to me in this case.

comment:18 Changed 12 years ago by fingolfin

I'd say we should upload the DXA movies now, and not wait with it (what purpose would that serve?). This way we'd get more in-the-field-testing, too.
And I don't see why we should remove the MPEG2 downloads either, at least for the time being -- they might still be interesting for people with systems with less storage memory, no?

In either case, a gradual phasing-over from MPEG2 to DXA would appear wiser than just making a hard cut one day...

comment:19 Changed 12 years ago by sev-

Okay, the movies were up for a long time, and we are going to announce full support of DXA cutscenes in 0.10.0. So I am closing this as fixed.

comment:20 Changed 12 years ago by sev-

Owner: set to sev-
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.