Opened 15 years ago

Closed 15 years ago

Last modified 19 months ago

#2095 closed defect (fixed)

GUI: Language selection doesn't fit using 1x overlay

Reported by: joostp Owned by: eriktorbjorn
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

Using latest CVS, when using --force-1x-overlay the dropdown list of languages is too big to fit on-screen, so the bottom ones get cut-off (and you can't select them).

Maybe this can be made into a scrollable dialog? The attached screenshot demonstrates the issue.

Ticket imported from: #1243280. Ticket imported from: bugs/2095.

Attachments (2)

gui-language-bug.png (10.2 KB ) - added by joostp 15 years ago.
Demonstrating GUI issue with 1x overlay
language-twocolumns.png (10.8 KB ) - added by eriktorbjorn 15 years ago.
Screenshot with the patch

Download all attachments as: .zip

Change History (10)

by joostp, 15 years ago

Attachment: gui-language-bug.png added

Demonstrating GUI issue with 1x overlay

comment:1 by joostp, 15 years ago

Summary: GUI:Language selection doesn't fit onscreen using 1x overlayGUI: Language selection doesn't fit using 1x overlay

by eriktorbjorn, 15 years ago

Attachment: language-twocolumns.png added

Screenshot with the patch

comment:2 by eriktorbjorn, 15 years ago

Owner: set to fingolfin

comment:3 by eriktorbjorn, 15 years ago

I've submitted a simple patch (#1263153) to work around the problem. It's not perfect by any means, but maybe it's good enough for 0.8.0? Fingolfin should probably have a say in the matter, though, since he's done most of the work on the GUI as far as I know.

In the meantime, I'm attaching a screenshot of what it looks like with the patch. The string "Norwegian Bokml" isn't rendered correctly, but that shouldn't have anything to do with the patch. The small font probably lacks the letter "".

comment:4 by fingolfin, 15 years ago

Well, if it works fine, feel free to commit it. I still prefer the scrolling menu solution, however, the major advantage with your solution is that it actually is already implemented and working... :-)

Thanks for your work!

comment:5 by eriktorbjorn, 15 years ago

I agree that scrolling would be nicer but I figured that would be harder to implement. It would also mean having the change the behaviour of the pop-up dialog: It is currently removed when the mouse button is released, which obviously would make it hard to scroll. I figured that the patch might be good enough for the next stable release, and a better way can perhaps be implemented later.

I'm out of town for the weekend though, and won't be able to commit it until I return. If someone else wants to do it before then, that's fine with me.

comment:6 by eriktorbjorn, 15 years ago

Owner: changed from fingolfin to eriktorbjorn
Resolution: fixed
Status: newclosed

comment:7 by eriktorbjorn, 15 years ago

I've applied the patch, but do feel free to implement scrolling any time you feel like it.

comment:8 by digitall, 19 months ago

Component: GUI
Note: See TracTickets for help on using tickets.