Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#1986 closed defect (duplicate)

MI2: Native MT-32 mode corrections

Reported by: SF/tbcarey Owned by: kingguppy
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 2

Description

I noticed the following two issues regarding Native
MT-32 playback in MI2 while testing some other MIDI
settings:

1) 'Memory | glop' [sound effect played back when game
mode is selected] ought to have no reverb. Right now it
is at default level.
2) During Largo's music in the very beginning of the
game, 'Memory | Sax4' ought to be mapped to Part 1.
Instead, it is 'Wind-2 | Bassoon' in ScummVM.

Ticket imported from: #1177542. Ticket imported from: bugs/1986.

Attachments (2)

MI2 Largo DOSBox Real MT-32.mp3 (164.5 KB ) - added by SF/tbcarey 15 years ago.
MI2 Largo ScummVM Real MT-32.mp3 (161.8 KB ) - added by SF/tbcarey 15 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 by fingolfin, 15 years ago

Component: Engine: SCUMM
Game: Monkey Island 2
Owner: set to kingguppy

comment:2 by kingguppy, 15 years ago

1) This is a duplicate of #1088045
2) This seems to be a duplicate of tbcarey's own feature
request #1177537

comment:3 by kingguppy, 15 years ago

Resolution: duplicate
Status: newclosed

comment:4 by SF/tbcarey, 15 years ago

Status: closednew

comment:5 by SF/tbcarey, 15 years ago

2) No, it's actually the incorrect instrument being played
altogether, not just being written to the display
improperly. If you check out instrument.cpp, you'll note
that Sax4 isn't even included in the MT32 -> GM mapping. I
don't know why bassoon2 would be chosen instead, but it's
definitely not the correct instrument. I'll attach a sample
of the real output vs. scummvm's if you like.

by SF/tbcarey, 15 years ago

comment:6 by SF/tbcarey, 15 years ago

I'm attaching two copies of Largo's music with Part 1
soloed/semi-soloed (ScummVM writes the rhythm part volume
with every note, so it's impossible to turn the volume down
to 0 like one can do with the original). The first is played
back with the original interpreter under DOSBox, and the
second with the latest ScummVM CVS. Obviously, they're both
on an actual MT-32.

by SF/tbcarey, 15 years ago

comment:7 by kingguppy, 15 years ago

From my testing, both the original interpreter (used through
DOSBox) and ScummVM choose the "Bassoon" patch. Where do you
get "Sax4" from? There's no custom instrument by that name
in the resource files that I can see, but there is a
built-in "Sax 4" (in the "Wind-2" group).

I think it's using the correct instrument, but with reverb
(and possibly other parameters) misconfigured.

comment:8 by SF/tbcarey, 15 years ago

You're right, it is Wind-2 | Sax 4. I don't know why I had
assumed it was a custom instrument. At any rate, it
consistently chooses Wind-2 | Sax 4 under both DOSBox and
DOS 6.22 with both an English and Italian version of the
game. The interpreter versions are 5.2.28cd (Sep 06 1996
17:32:24) and 5.2.02 (Nov 21 1991 08:35:15).

Everything else seems to work fine (no error messages or
overflows), so I don't see why it would randomly choose the
incorrect patch.

comment:9 by kingguppy, 15 years ago

I really can't, under any circumstances, get MI2 running
under DOSBox to choose the Sax 4 program on the MT-32 - it
chooses Bassoon, like ScummVM. I'm also using 5.2.28cd.

comment:10 by kingguppy, 15 years ago

Status: newclosed

comment:11 by SF/tbcarey, 15 years ago

I suppose it's a very unimportant issue anyway. Both
original interpreters do select Bassoon for Largo's room
music, and in other subtle queues; however, for the main
music, without fail, they both choose Sax 4. There is other
music that correctly chooses both Bassoon and Sax 4 for
different parts, so I wonder why there's the differentiation
on just that one piece. At any rate, not a huge deal.

comment:12 by kingguppy, 15 years ago

You mean the bit where Guybrush first meets Largo on the
bridge, right? I really, truly get "Bassoon" assigned to
part 1 consistently with the original interpreter. Let's
just pretend that everything's working fine - it sounds
correct with the reverb fixes I've made locally, anyway.

Note: See TracTickets for help on using tickets.