Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#1931 closed defect

EXTRACT: Failure to recompress Sam & Max (floppy)

Reported by: SF/alxyz Owned by: Kirben
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Sam and Max

Description

When trying to recompress MONSTER.SOU from Sam & Max (floppy disk version, 2,256,495 bytes), the produced file MONSTER.SOF is only 4 bytes long. No error messages are given. If trying to use mp3 and produce MONSTER.SO3, the result is the same.

Ticket imported from: #1144526. Ticket imported from: bugs/1931.

Attachments (2)

extract.c (6.4 KB ) - added by SF/alxyz 16 years ago.
Updated extract.c
compress_scumm_sou.c (6.4 KB ) - added by SF/alxyz 16 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by fingolfin, 16 years ago

What output does the tool produce?

comment:2 by SF/alxyz, 16 years ago

No output at all, that's why I'm so confused about what to do next. The command line I used is "extract --flac --best -b 1152 -f MONSTER.SOU". Is there any way to try to analyse the offending file?

By the way, the "-f" key of flac should probably be introduced into the readme; the recompression does not work without it as flac.exe refuses to overwrite the temporary output file by default.

comment:3 by SF/alxyz, 16 years ago

Something I forgot to mention: these four bytes in the generated MONSTER.SOF (or MONSTER.SO3) are all zeros.

comment:4 by SF/alxyz, 16 years ago

Ok, I just found what is wrong with it. Instead of using standard VCTL markers, MONSTER.SOU from "Sam&Max Demo" and "Sam&Max (floppy)" use VTTL. There seems to be no other differences. I've made a necessary correction to extract.c; please find it attached.

by SF/alxyz, 16 years ago

Attachment: extract.c added

Updated extract.c

by SF/alxyz, 16 years ago

Attachment: compress_scumm_sou.c added

comment:5 by SF/alxyz, 16 years ago

To make things simpler for you, I've just introduced the necessary correction into the latest version of this tool (compress_scumm_sou.c, ver.1.4). Since I've started working on it, I'll probably sort out passing the parameters to FLAC, using compress.c (ver.1.7) as the starting point.

comment:6 by Kirben, 16 years ago

Status: newclosed

comment:7 by Kirben, 16 years ago

Thanks for the patch, I add it to tools cvs.

For future patches, please provide a diff instead and use the patch tracker.

comment:8 by Kirben, 16 years ago

Owner: set to Kirben
Note: See TracTickets for help on using tickets.