Opened 15 years ago

Closed 15 years ago

Last modified 12 months ago

#1882 closed defect (fixed)

TOOLS/OSX: compress_san endian bug

Reported by: SF/pwigren Owned by: aquadran
Priority: high Component: Tools
Keywords: Cc:
Game:

Description

After compressing .san-files with compress_san on my G5, they
sound like they are being played through a death metal distortion
pedal... :)

Ticket imported from: #1098635. Ticket imported from: bugs/1882.

Change History (9)

comment:1 by fingolfin, 15 years ago

Did you modify the Makefile for big endian compilation?

comment:2 by fingolfin, 15 years ago

Status: newpending

comment:3 by SF/pwigren, 15 years ago

No I didn't. :)
But I tried again and it didn't help.. Not for compress_san anyway...

comment:4 by SF/pwigren, 15 years ago

Status: pendingnew

comment:5 by fingolfin, 15 years ago

Owner: set to aquadran
Priority: normalhigh
Summary: Mac OS X/tools: compress_san endian bugTOOLS/OSX: compress_san endian bug

comment:6 by fingolfin, 15 years ago

Aquadran, hm, isn't this (line 425) endian unsafe:
int16 wavSampleL = *(int16 *)(wavBuf + offset + r + 0);

At least if I am reading the code correctly... I assume the
code should be using TO_LE_16 there.

comment:7 by aquadran, 15 years ago

i did changes to cvs for that issue, so someone need to
check that

comment:8 by aquadran, 15 years ago

Resolution: fixed
Status: newclosed

comment:9 by digitall, 12 months ago

Component: Tools
Note: See TracTickets for help on using tickets.