Opened 18 years ago

Closed 18 years ago

#188 closed defect (fixed)

indy 4 crash at start

Reported by: SF/logicdeluxe Owned by: SF/ender
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Indiana Jones 4

Description

Built on Apr 25 2002 21:10:18 win talkie version

The Indy logo is messed up and the moment Indy should appear Scummvm terminates: Detected game 'Indiana Jones 4 and the Fate of Atlantis', version 5.5.0 WARNING: roomops:14 load-string(31,"iq-points") not implemented! Loading room 68 Adding object 933 from room 68 into inventory Adding object 937 from room 68 into inventory Adding object 938 from room 68 into inventory Loading room 0 Loading room 4 Error(4:206:0xD877): Value 1024 is out of bounds (0,799) int script(206) msg Variable %d out of range(r)!

It worked with Built on Apr 23 2002 07:37:56

Ticket imported from: #548672. Ticket imported from: bugs/188.

Change History (4)

comment:1 by SF/mnepomuk, 18 years ago

Found. Reason is the ugly handling of '_gameId' in if- statements, where a logical AND is used (&) instead of a direct comparance (==). So the result of the if-statements are a matter of choosing the "right" values in the enum- gameId statement, which is crap. There are several occurance of that spreaded over some files.

Either have to switch to a binary driven gameId (I guess this is not necessary) or correct the &'s to =='s. I cannot decide this.

Mikesch

P.S.: Shame: I made the same mistakes in my patches ;-(

comment:2 by SF/mnepomuk, 18 years ago

Found. Reason is the ugly handling of '_gameId' in if- statements, where a logical AND is used (&) instead of a direct comparance (==). So the result of the if-statements are a matter of choosing the "right" values in the enum- gameId statement, which is crap. There are several occurance of that spreaded over some files.

Either have to switch to a binary driven gameId (I guess this is not necessary) or correct the &'s to =='s. I cannot decide this.

Mikesch

P.S.: Shame: I made the same mistakes in my patches ;-(

comment:3 by SF/ender, 18 years ago

Owner: set to SF/ender
Resolution: fixed
Status: newclosed

comment:4 by SF/ender, 18 years ago

Fixed.

Note: See TracTickets for help on using tickets.