Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#1513 closed defect (fixed)

BS1: Missing cursor in the savegame dialog.

Reported by: SF/helh Owned by: lavosspawn
Priority: normal Component: Engine: Sword1
Keywords: Cc:
Game: Broken Sword 1

Description

There used to be a blinking cursor in the "Save"-dialog whenever I clicked on a savegame slot, at least with the original interpreter there is one. Currently, by clicking on a savegame slot, it gets "highlighted" with no cursor present. It made me believe something was wrong, although i only had to type in a name and then press "save". I was told that BS2 has this blinking cursor, so I guess it just got lost somehow, but I don't know since when this error occurs.

Specs: Windows XP ScummVM Windows Daily build March 2 2004 23:42:00 English version of Broken Sword 1

Ticket imported from: #908679. Ticket imported from: bugs/1513.

Change History (7)

comment:1 by eriktorbjorn, 16 years ago

Owner: set to lavosspawn

comment:2 by eriktorbjorn, 16 years ago

It's true that the blinking cursor is there in BS2. Unfortunately, BS1 and BS2 don't share any code except for the ScummVM infrastructure.

Assigning to lavosspawn, since he wrote the current BS1 control panel code.

comment:3 by Kirben, 16 years ago

Summary: Missing cursor in the savegame dialog.BS1: Missing cursor in the savegame dialog.

comment:4 by eriktorbjorn, 16 years ago

Another thing missing from the BS1 save/restore dialog is that the savegames aren't numbered.

comment:5 by eriktorbjorn, 16 years ago

Another few things the save/restore dialog could handle better:

* You should be able to press and hold down a scroll button to scroll several lines/screens. As it is now, I believe you have to press the button once for each line/screen.

* The length of the savegame name should be limited, not just by the number of characters but by the width of the string. Right now you can type a name wider than the input field, if you use wide characters such as "W".

* The save/restore slots react both when you press and release the button, which can lead to glitches where for instance the button pops back up but the text inside it remains red.

* It'd be nice if you could use the mouse wheel to scroll the savegame list.

I believe the BS2 save/restore dialog handles all these things, but unfortunately the code base is just too different to borrow any code directly. (In both cases, the original code was replaced with brand new code, but by two different persons.)

comment:6 by eriktorbjorn, 16 years ago

I guess lavosspawn's been too busy to look at this, so I've added blinking cursor, numbered savegame slots and mouse wheel support myself. There are still things I would like to see fixed, but this should take care of the most obvious deficiencies.

I hope this patch will be allowed in 0.6.1, but I don't know for sure.

comment:7 by eriktorbjorn, 16 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.