Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#1388 closed defect (outdated)

BS2: Warehouse crashes

Reported by: SF/ender Owned by: SF/ender
Priority: high Component: Engine: Sword2
Keywords: Cc:
Game: Broken Sword 2

Description

I decided to give Broken Sword 2 a testrun last night
as I've never played the game so it'd be good as a
test of the engine under normal (eg, no speedruns :)
conditions.

When I rescued Nico from the warehouse (Manacles +
Dock rope), the engine segfaulted and I didn't manage
to catch a backtrace.

I reloaded from my last save game (outside the
warehouse, before knocking Pablo out) and upon going
back upstairs I found the scratchmarks and all
indiciations of the door were missing).

Both the original save game and a save from upstairs
without the marks are attached.

Ticket imported from: #876537. Ticket imported from: bugs/1388.

Attachments (2)

sword2.000 (443 bytes) - added by SF/ender 15 years ago.
BS2 - Initial savegame outside Warehouse
sword2.001 (489 bytes) - added by SF/ender 15 years ago.
BS2 - Save upstairs of Warehouse

Download all attachments as: .zip

Change History (10)

Changed 15 years ago by SF/ender

Attachment: sword2.000 added

BS2 - Initial savegame outside Warehouse

Changed 15 years ago by SF/ender

Attachment: sword2.001 added

BS2 - Save upstairs of Warehouse

comment:1 Changed 15 years ago by SF/ender

Priority: normalhigh

comment:2 Changed 15 years ago by eriktorbjorn

I won't have the time to look closer until this evening,
even to try and verify the bug report. (It isn't even noon
here yet). However, I'd like to eliminate the possible
simple causes before digging deeper, so I'm going to make
two quick observations:

Is the crash repeatable? This is one of the places where a
cutscene is played, though it's one without any speech or
subtitles. (There should have been one like that when Andr
shows you the stone, so that in itself wouldn't be a reason
to crash, I guess.)

As for the scratch marks, they are only visible if you turn
on the light. Perhaps you forgot to do that the second time?

comment:3 Changed 15 years ago by SF/ender

Owner: changed from eriktorbjorn to SF/ender

comment:4 Changed 15 years ago by SF/ender

Oops, I did forget the switch. Okay, ignore that.

I can now report that the crash is indeed reproducable. Now that I
can, however, I can see it's a crash inside the mpeg2 palette code so
am reassigning this to myself :P

comment:5 Changed 15 years ago by SF/ender

Which was fixed as a result of the fscanf != 2 check in your
valgrind commit. Escape.pal must be malformed somewhere.

comment:6 Changed 15 years ago by SF/ender

Resolution: outdated
Status: newclosed

comment:7 Changed 15 years ago by eriktorbjorn

Well... Not necessarily malformed. At least I *though* I
added that fscanf test to catch the case where it had
reached the end of the file, but the end-of-file flag hadn't
yet been raised. :-)

comment:8 Changed 15 years ago by SF/khalek

Component: --Unset--Engine: Sword2
Game: Broken Sword 2
Note: See TracTickets for help on using tickets.