TOON: Toonstruck music not playing 2.6.0

[Scapetti]

It worked fine in the previous stable release

[antoniou79]

Please provide more details on this issue.
Which platform are you playing on? (Windows, Linux etc)
Which version of the game do you have? (GOG, Steam, original boxed release etc)

I've just re-tested with the final 2.6.0 stable release on Windows 10 x64 with the GOG version of the game and I do get music in-game.

Please make sure you have not accidentally muted music or lowered its volume way down from the in-game menu (F1) or the ScummVM in-game menu (typically brought up with Ctrl-F5)

[dwatteau]

I think I can reproduce this with 2.7.0git1616-g3a9f80451bc on macOS 12.5 x64.

I had both the English and French versions (from GOG), and it seems unlikely that I would have muted the music by accident in both (I also don't mute anything in my global settings).

Here's what I had by default when starting the game:

[toon]
engineid=toon
gui_saveload_last_pos=0
platform=pc
guioptions=sndNoMIDI lang_English
description=Toonstruck (DOS/English)
path=/path/to/TOONSTRUCK_EN
gameid=toon
language=en

and to get any music, I had to press F1 and check the SFX and music buttons, which changed my config to this:

[toon]
engineid=toon
gui_saveload_last_pos=0
platform=pc
guioptions=sndNoMIDI lang_English
description=Toonstruck (DOS/English)
path=/path/to/TOONSTRUCK_EN
gameid=toon
language=en
music_mute=false
sfx_mute=false

i.e. music_mute=true and sfx_mute=true act like they're the defaults? Although toon.cpp seems to say otherwise.

[antoniou79]

Ah, you're right. I've added the game anew, and music and sfx are muted by default.

I'll debug to see what's going on. At least I can reproduce it so it should be easy to fix (and a possible bugfix release ie. 2.6.1 will get it).

[Scapetti]

Thanks guys, sorry I didn't provide more details, I was in a rush but decided to post anyway in case I forgot. Glad you figured it out!

By the way, something completely aside. I was surprised that Escape from Monkey Island still isn't playable in this stable release despite the pre-warning. Was it intentionally still disabled in this release? Just to check, thanks!

[antoniou79]

I think I got it. By mistake I didn't use a variable when setting the mute state of the sound types, and in this particular case, when no additional custom volume setting was done, they were getting muted.

The fix was committed here:
​https://github.com/scummvm/scummvm/commit/e55490a8ba3976bb5f4c97566846d9421098d2a0

and it's cherrypicked for the 2.6 branch too.

[antoniou79]

Replying to Scapetti:

By the way, something completely aside. I was surprised that Escape from Monkey Island still isn't playable in this stable release despite the pre-warning. Was it intentionally still disabled in this release? Just to check, thanks!

Yes, I believe it's intentional, but I'm not exactly certain what's keeping it. Probably some known issues (?) I know there are a few people who mentioned path finding issues with Guybrush at some locations. Anyway, this is not something to discuss in this ticket.

[Scapetti]

No problem, thanks for the information!