Opened 13 days ago

Closed 40 hours ago

#13742 closed defect (fixed)

Detection of missing sci-fanmade games

Reported by: treloret Owned by: bluegr
Priority: normal Component: Engine: SCI
Version: Keywords: sci-fanmade
Cc: Game:

Description

Checked against the sciprogramming.com website for mass adding them to the latest version of scummvm, found numerous missing and some errors:

  • Dr. Jummybummy's Space Adventure 2 wasn't detected
  • Island of Secrets Demo 0.4 wasn't detected (0.3 was)
  • SCI VGA Demo Update-Remake wasn't detected (requires patch.003 found in SQ4 EGA to get it running)
  • Scene Builder wasn't detected
  • The Dating Pool Demo (2016 One Day) was misnamed (2019 One Day), timestamps and original zipfile clearly show it to be 2016
  • Osama Been Skatin' was named plainly Osama
  • SCI Tetris was also not detected, but after adding detection, it crashed on startup
  • Zork Demo wasn't detected, but after adding detection, it too crashed on startup

Another issue was that Dating Pool Demo
In the original detection.cpp it has a separate entry as SCI1.1+ game catdate, this is never detected and never used.

Attachments (1)

scifanmadechanges.diff.txt (7.0 KB ) - added by treloret 13 days ago.
Changes I tested to get most of the games working

Download all attachments as: .zip

Change History (5)

by treloret, 13 days ago

Attachment: scifanmadechanges.diff.txt added

Changes I tested to get most of the games working

comment:1 by treloret, 7 days ago

Owner: set to treloret
Resolution: assigned
Status: newclosed

Gonna dabble in fixing stuff myself

comment:2 by treloret, 7 days ago

Status: closedpending

comment:3 by sluicebox, 7 days ago

Good idea, you can break it up into smaller pieces and even submit them as PRs.

I don't think there's a particular policy here, but I see a detection entry as some kind of promise that the game runs in some form. So for fan games, I think it's good that at least one knowledgeable person has tried each out. Otherwise it would be kind of weird for ScummVM to detect the game, know the name, and then just crash immediately or something.

And I think in this case that "one person" is going to be you! =)

For an example of how "just a fan game detection entry" can turn into something much bigger once someone tries playing the game: #11552

Haha, although the wrong lesson to take from that is that I'll play your fan games and add all the third party features they rely on and fix all the memory corruption they do. That was a rare exception! =)

comment:4 by bluegr, 40 hours ago

Owner: changed from treloret to bluegr
Resolution: assignedfixed
Status: pendingclosed

Fixed in the following PR:
https://github.com/scummvm/scummvm/pull/4173

Closing

Note: See TracTickets for help on using tickets.