WIN32: Wrong implicit icons path when no icons path is set in configuration file

[lotharsm]

Currently, when no icons path is set in the configuration and ScummVM tries set the proper icons path by itself, it adds a "stray" ScummVM folder within the %APPDATA% directory.

Instead of %APPDATA%/ScummVM/Icons, it puts the files in %APPDATA%/ScummVM/ScummVM/Icons.

Since the wrong path is used not only for downloading the icon files, there's no visible error for the end user.

It does break the "Clear cache" functionality though, since the dummy files that are used to overwrite the current icons data are created as %APPDATA%/ScummVM/ScummVM/Iconsgui-icons-20211112.dat (note the missing / in "Iconsgui").

Tested with the current stable release 2.6.0 on Windows 11.

[lotharsm]

Looks like the issue is in the Win32 platform code itself, so other platforms are likely not affected.

[lotharsm]

Fixed for Win32:

​https://github.com/scummvm/scummvm/commit/3d5a93ce42756c614b52a9ae22dd8d4dc0273ad1
​https://github.com/scummvm/scummvm/commit/795a92f8193875e312773c8578ea2f7428e9907b

[lotharsm]

Backported to branch-2-6 as well, but could need more testing. We also need to verify other platforms are not affected.

[lotharsm]

Cache clearing issue should be fixed with:

​https://github.com/scummvm/scummvm/commit/1690f882ba070c9eda424654ee00b1c1f7b3f648

Tested on Win32 and on macOS (thanks a lot to criezy for helping me with this!), but it wouldn'T hurt if someone could validate the test results with an "empty" icons path and after setting one manually...

[lotharsm]

Tested on Win32 and Linux by myself while criezy already confirmed macOS as working.

Closing.