Opened 21 years ago
Closed 20 years ago
#1064 closed defect (fixed)
DOTT: Actor glides instead of walks (regression)
| Reported by: | eriktorbjorn | Owned by: | Kirben |
|---|---|---|---|
| Priority: | low | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: | Day of the Tentacle |
Description
[Extracted from bug report #775097]
English CD "talkie" version
At the end, when the kids are running away from purple tentacle, there's a brief sequence on the second floor where they are gliding instead of walking. I think this used to work, but I can't say for sure when that was.
I think it may have something to do with startWalkAnim() not being called from actorWalkStep(), but I don't know how to fix it.
I'm pretty sure this used to work the last time I played the game - somewhere between 0.2.0 and 0.3.0 probably. I don't know about 0.4.0 / 0.4.1.
Ticket imported from: #775662. Ticket imported from: bugs/1064.
Attachments (3)
Change History (15)
by , 21 years ago
| Attachment: | tentacle.s32.gz added |
|---|
comment:1 by , 21 years ago
Well startWalkAnim() is not being called because facing == direction == 90 and also frame == walkFrame == 2.
That's correct logic: if the frame is already the walkFram, and we are not turning: don't do aynthing. Otherwise, you'd get stutter in the movement. So, the question remains, why doesn't the actor 'walk' properly? Is 'frame' maybe out of sync with reality? Or is for some reason the actor animation counter not being incremented?
comment:3 by , 21 years ago
According to disasm., frame should always be set to 0 in startAnimActor() for tentacle, which triggers a walk in this situation. I have added fix to cvs.
comment:4 by , 21 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:5 by , 21 years ago
| Owner: | removed |
|---|---|
| Resolution: | fixed |
| Status: | closed → new |
comment:7 by , 21 years ago
| Priority: | normal → low |
|---|
comment:8 by , 21 years ago
Since I've played through DOTT with a January 23 CVS snapshot, I can confirm the glitch is still there. I'm attaching an up-to-date savegame.
comment:9 by , 20 years ago
| Summary: | DOTT: Actor glides instead of walks (regression?) → DOTT: Actor glides instead of walks (regression) |
|---|
comment:10 by , 20 years ago
This is a regression but it only worked before actor.frame support was added.
comment:11 by , 20 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:12 by , 20 years ago
The problem was we were changing the value of actor.frame even if the actor's frame was not updated. Verified by disasm.
Savegame near the end of the game