Opened 21 months ago

Closed 20 months ago

Last modified 4 months ago

#9865 closed enhancement (wontfix)

performance related

Reported by: necros2k7 Owned by: csnover
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

[backends\platform\ps2\savefilemgr.cpp:120] -> [backends\platform\ps2\savefilemgr.cpp:123]: (performance) Buffer 'path' is being written before its old content has been used.
[devtools\create_project\msbuild.cpp:83]: (performance) Function parameter 'toolset' should be passed by reference.
[devtools\create_project\msbuild.cpp:289]: (performance) Function parameter 'configuration' should be passed by reference.
[devtools\create_project\msbuild.cpp:414]: (performance) Function parameter 'configuration' should be passed by reference.
[devtools\create_project\msvc.cpp:37]: (performance) Variable '_enableLanguageExtensions' is assigned in constructor body. Consider performing initialization in initialization list.

Change History (2)

comment:1 Changed 20 months ago by csnover

Owner: set to csnover
Resolution: wontfix
Status: newclosed

Thanks for your report! Please go ahead and submit a pull request on GitHub if you would like to fix these things, otherwise I don’t think these changes will be made since the dev tools aren’t an area of performance concern and the PS2 port is currently unmaintained.

comment:2 Changed 4 months ago by digitall

Component: --Unset----Other--
Note: See TracTickets for help on using tickets.