Opened 8 years ago

Closed 8 years ago

Last modified 13 months ago

#9359 closed patch (outdated)

Tools: Fix configure with updated MinGW g++

Reported by: SF/agf863 Owned by: lordhoto
Priority: normal Component: Tools
Keywords: Cc:
Game:

Description

I updated my MinGW / MSYS with mingw-get yesterday and today g++ crashes during configure for ScummVM Tools.

I traced the problem to configure's use of the environment's TMP variable. g++ 4.5.2 seems to expect this to be set to a valid temporary directory. It crashes the second time it is called because after the first call TMP is set to it's return value.

I simply changed configure to use RETVAL (what it's actually storing) instead of TMP in this patch.

Ticket imported from: #3309021. Ticket imported from: patches/1464.

Attachments (1)

configure-g++-mingw-crash.patch (1.1 KB ) - added by SF/agf863 8 years ago.
Fix configure for g++ 4.5.2 on MinGW

Download all attachments as: .zip

Change History (5)

by SF/agf863, 8 years ago

Fix configure for g++ 4.5.2 on MinGW

comment:1 by lordhoto, 8 years ago

A similar fix had been applied to ScummVM's main configure with bd253a62aca2a0571ad61a3167278d3c5437467a.

It seems the tools configure script still has not been updated yet, since there is other changes to be merged from the scummvm sources, I am not quite sure whether we should apply this patch now or just port the above mentioned commit when merging.

comment:2 by lordhoto, 8 years ago

I updated the tool's configure script with the changes of the main repo now. It should work again with MinGW. Thank you for your patch never the less.

Commit e3fad4057d13bdb28cde.

comment:3 by lordhoto, 8 years ago

Owner: set to lordhoto
Resolution: outdated
Status: newclosed

comment:4 by digitall, 13 months ago

Component: Tools
Note: See TracTickets for help on using tickets.