Opened 9 years ago

Closed 9 years ago

Last modified 13 months ago

#9302 closed patch (wontfix)

SCI: Do not fade rhythm channel

Reported by: tsoliman Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: MIDI MT-32 Cc:
Game: Quest for Glory 2

Description

There's a problem in QFG2's Shema dance sequence where the rhythm is being faded because of scene change.
This drops the volume of rhythm channel down to zero causing the perception of missing notes.
You can see the notes being played in the MT-32's LCD but the volume slowly drops to 0 and stays there.
SSCI doesn't seem to fade rhythm.

Ticket imported from: #3266467. Ticket imported from: patches/1407.

Attachments (2)

0001-SCI-do-not-fade-rhythm-channel.patch (2.3 KB ) - added by tsoliman 9 years ago.
patch to skip channel 9 volume adjustment only if fading
0001-SCI-do-not-fade-rhythm-channel-revised-1.patch (2.3 KB ) - added by tsoliman 9 years ago.
revised patch after using MIDI_RHYTHM_CHANNEL as instructed by thebluegr

Download all attachments as: .zip

Change History (8)

by tsoliman, 9 years ago

patch to skip channel 9 volume adjustment only if fading

comment:1 by bluegr, 9 years ago

Looks good at a first glance :) Will check it over in the weekend

Quick change: use MIDI_RHYTHM_CHANNEL instead of 9 for the rhythm channel (defined in sci/sound/drivers/mididriver.h)

comment:2 by bluegr, 9 years ago

Owner: set to bluegr

by tsoliman, 9 years ago

revised patch after using MIDI_RHYTHM_CHANNEL as instructed by thebluegr

comment:3 by tsoliman, 9 years ago

Good catch. New patch uploaded

comment:4 by bluegr, 9 years ago

Resolution: wontfix
Status: newclosed

comment:5 by bluegr, 9 years ago

Thanks for your work, however I'm reluctant to add separate fade handling for the rhythm channel. I've applied an alternate fix in rev 9654068 (more information in the associated bug report).

Therefore, this patch is unfortunately rejected in this form, however it did help in pinpointing the actual bug

comment:6 by digitall, 13 months ago

Component: Engine: SCI
Game: Quest for Glory 2
Keywords: MIDI MT-32 added
Note: See TracTickets for help on using tickets.