Opened 9 years ago

Closed 9 years ago

Last modified 9 months ago

#9161 closed patch

Tools GUI: fix use of mp3 AVR target bit rate

Reported by: criezy Owned by: criezy
Priority: normal Component: Tools
Keywords: Cc:
Game:

Description

Reviewing my patch #2981339 I noticed I made a mistake. The CompresionTool store the VBR minimum bit rate and the ABR target bit rate in the same variable. Because the GUI Tools now pass both to the CompressionTool and the second one is the VBR minimum bit rate, when encoding using MP3 ABR it will use the bit rate specified in the disabled VBR minimum bit rate combobox instead of the one from the ABR target bit rate combobox.
This patch fixes this by setting either the ABR target bit rate or the VBR minimum and maximum bit rates in the CompresionTool depending if the user chose ABR or VBR.

Ticket imported from: #2982306. Ticket imported from: patches/1266.

Attachments (1)

tools_gui_mp3_options.patch (1.2 KB) - added by criezy 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by criezy

Attachment: tools_gui_mp3_options.patch added

comment:1 Changed 9 years ago by criezy

Status: newclosed

comment:2 Changed 9 years ago by criezy

Patch committed in trunk and 1.1.0 branch.

comment:3 Changed 9 years ago by criezy

Owner: set to criezy

comment:4 Changed 9 months ago by digitall

Component: Tools
Note: See TracTickets for help on using tickets.