Opened 10 years ago

Closed 10 years ago

Last modified 13 months ago

#9159 closed patch

CONFIG: Use HE keyword instead of HB for the Hebrew language

Reported by: salty-horse Owned by: salty-horse
Priority: low Component: --Other--
Keywords: Cc:
Game:

Description

The ISO 639-1 two-letter code for Hebrew language is "he".
ScummVM uses "hb" in the config file and target names, and HB_ISR in the code to refer to the language.
I'm not sure where HB got from, but it's wrong.

Since the "hb" string is used in users' configuration files as "language=hb" entries, the values in the config file should probably be upgraded.
I'm not sure what's the best strategy to do that, or if it's even required.
At the moment, the patch still understands "hb" as hebrew, but any new values will be written as "he".

The patch includes the generated scumm md5 table, just so it would compile when testing the patch.

Ticket imported from: #2982163. Ticket imported from: patches/1264.

Attachments (1)

hebrew.patch (29.7 KB ) - added by salty-horse 10 years ago.
Suggested patch

Download all attachments as: .zip

Change History (5)

by salty-horse, 10 years ago

Attachment: hebrew.patch added

Suggested patch

comment:1 by fingolfin, 10 years ago

Looks good to me, esp. since the patch seems to make it possible to still use "hb", so old config files will work.

I'll add this to my list of things that should be auto-converted to the new format at some point (once we introduced properly version config files).

Please go ahead and commit.

comment:2 by salty-horse, 10 years ago

Status: newclosed

comment:3 by salty-horse, 10 years ago

Committed as r48645

comment:4 by digitall, 13 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.