Opened 11 years ago

Closed 11 years ago

Last modified 2 years ago

#9128 closed patch

SOMI: Kanji support for japanese MegaCD version

Reported by: SF/tobigun Owned by: sev-
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Monkey Island 1

Description

This patch adds support for the Kanji font in the japanese MegaCD version of Secret of Monkey Island. The Kanji font is stored in charset 5.

Ticket imported from: #2923628. Ticket imported from: patches/1233.

Attachments (1)

monkey_segacd_kanji.patch (1.7 KB ) - added by SF/tobigun 11 years ago.

Download all attachments as: .zip

Change History (6)

by SF/tobigun, 11 years ago

Attachment: monkey_segacd_kanji.patch added

comment:1 by sev-, 11 years ago

Excellent! Committed as is.

comment:2 by sev-, 11 years ago

Owner: set to sev-
Status: newclosed

comment:3 by eriktorbjorn, 11 years ago

One small thing. GCC warned about the following line:

idx = ((idx & 0x7F) << 8) | ((idx >> 8) & 0xFF) - 1;

It said, "suggest parentheses around arithmetic in operand of ‘|’", and I think I'd have to agree with that. I'm not sure if this is supposed to mean (X | (Y - 1)) or ((X | Y) - 1). Operator precedence makes it the former, but the latter seems more likely to me. (It makes a difference if Y is 0.)

comment:4 by SF/tobigun, 11 years ago

Thanks eriktorbjorn. I thought i typed ((X | Y) - 1) but the large amount of parantheses made me a little bit confused. The correct line should be

idx = (((idx & 0x7F) << 8) | ((idx >> 8) & 0xFF)) - 1;

comment:5 by digitall, 2 years ago

Component: Engine: SCUMM
Game: Monkey Island 1
Note: See TracTickets for help on using tickets.