#9114 closed patch
PSP: compile cleanup/fix for gprof and Windows
| Reported by: | bluddy | Owned by: | joostp |
|---|---|---|---|
| Priority: | normal | Component: | Port: PSP |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
PSP libs are now grouped together as gprof requires. Also, I check extensively to make sure libraries aren't added if they aren't required. Hopefully this version will compile in Linux, OSX and Windows toolchains. Also, I'm hoping this somehow takes care of the PSP's 'undead' flicker bug, which only appears when _end is located on an address that ends in 0x14 (LSB).
Ticket imported from: #2903175. Ticket imported from: patches/1219.
Attachments (1)
Change History (7)
by , 14 years ago
| Attachment: | patch.diff added |
|---|
comment:1 by , 14 years ago
| Owner: | set to |
|---|
comment:2 by , 14 years ago
comment:3 by , 14 years ago
Yes. If SDL is built with opengl support, opengl needs to be included. And unfortunately it is in MINPSPW. Normally we'd just include sdl-config --libs's output, which would include any prerequisites including opengl. However, since we don't want to do that because it would interrupt the psp libs, we detect if opengl is a requirement and if so we include it.
comment:4 by , 14 years ago
| Status: | new → closed |
|---|
comment:6 by , 5 years ago
| Component: | → Port: PSP |
|---|---|
| Summary: | PSP: compile cleanup/fix for gprof and Windows → PSP: compile cleanup/fix for gprof and Windows |
Thanks for the patch.
I'll review it more thoroughly tonight, but first observation: what is the point of linking -lGL at all? OpenGL isn't being used by the port. Is your SDL built with OpenGL support and it somehow requires linking this lib, even though it's not referenced?!