Opened 11 years ago

Closed 11 years ago

Last modified 21 months ago

#9114 closed patch

PSP: compile cleanup/fix for gprof and Windows

Reported by: bluddy Owned by: joostp
Priority: normal Component: Port: PSP
Keywords: Cc:
Game:

Description

PSP libs are now grouped together as gprof requires. Also, I check extensively to make sure libraries aren't added if they aren't required. Hopefully this version will compile in Linux, OSX and Windows toolchains. Also, I'm hoping this somehow takes care of the PSP's 'undead' flicker bug, which only appears when _end is located on an address that ends in 0x14 (LSB).

Ticket imported from: #2903175. Ticket imported from: patches/1219.

Attachments (1)

patch.diff (2.0 KB ) - added by bluddy 11 years ago.

Download all attachments as: .zip

Change History (7)

by bluddy, 11 years ago

Attachment: patch.diff added

comment:1 by joostp, 11 years ago

Owner: set to joostp

comment:2 by joostp, 11 years ago

Thanks for the patch.

I'll review it more thoroughly tonight, but first observation: what is the point of linking -lGL at all? OpenGL isn't being used by the port. Is your SDL built with OpenGL support and it somehow requires linking this lib, even though it's not referenced?!

comment:3 by bluddy, 11 years ago

Yes. If SDL is built with opengl support, opengl needs to be included. And unfortunately it is in MINPSPW. Normally we'd just include sdl-config --libs's output, which would include any prerequisites including opengl. However, since we don't want to do that because it would interrupt the psp libs, we detect if opengl is a requirement and if so we include it.

comment:4 by joostp, 11 years ago

Status: newclosed

comment:5 by joostp, 11 years ago

Patch seems fine, committed to trunk. thanks again!

comment:6 by digitall, 21 months ago

Component: Port: PSP
Summary: PSP: compile cleanup/fix for gprof and Windows PSP: compile cleanup/fix for gprof and Windows
Note: See TracTickets for help on using tickets.