Opened 11 years ago

Closed 11 years ago

Last modified 23 months ago

#9103 closed patch

descumm: v0-5 expression-mode nested instruction semi-colons

Reported by: SF/jestar_jokin Owned by: fingolfin
Priority: normal Component: Tools
Keywords: Cc:
Game:

Description

This applies only applies to scripts for SCUMM v0 to v5. Changes made in patches 2865629 and 2870543 made semi-colons always appear at the end of instructions. However, the "expression" mode can output multiple nested instructions within the expression, leading to semi-colons appearing in the middle of the overall expression instruction.

This patch adds a workaround for the expression mode that will remove semi-colons from nested instructions within an expression.

Ticket imported from: #2890553. Ticket imported from: patches/1208.

Attachments (2)

descumm_expression_semicolon_hack.diff (422 bytes ) - added by SF/jestar_jokin 11 years ago.
patch made with TortoiseSVN unified diff
descumm.cpp (79.9 KB ) - added by SF/jestar_jokin 11 years ago.
source in case the diff doesn't work

Download all attachments as: .zip

Change History (5)

by SF/jestar_jokin, 11 years ago

patch made with TortoiseSVN unified diff

by SF/jestar_jokin, 11 years ago

Attachment: descumm.cpp added

source in case the diff doesn't work

comment:1 by SF/jestar_jokin, 11 years ago

To clarify what this fix entails, it basically changes this:

Exprmode Var[251] = (<VAR_RESULT = getRandomNr(4);> + 392);

To this:

Exprmode Var[251] = (<VAR_RESULT = getRandomNr(4)> + 392);

comment:2 by fingolfin, 11 years ago

Owner: set to fingolfin
Status: newclosed

comment:3 by digitall, 23 months ago

Component: Tools
Note: See TracTickets for help on using tickets.