Opened 10 years ago

Closed 10 years ago

Last modified 12 months ago

#9081 closed patch

AMIGAOS4: FS updated to new SDK

Reported by: raziel- Owned by: fingolfin
Priority: normal Component: Port: AmigaOS4
Keywords: Cc:
Game:

Description

I'm putting this diff up for revision.
Please feel free to comment, it has been slightly polished and modified to fit the needs and changes of the new SDK for AmigaOS4.
It has been tested and is working.

If i missed or abused some of the AcummVM coding or comment standards, please also feel free to correct me.

Thanks a lot

Ticket imported from: #2856708. Ticket imported from: patches/1186.

Attachments (1)

AmigaOS4.diff (12.6 KB ) - added by raziel- 10 years ago.
New diff file respecting the coding conventions

Download all attachments as: .zip

Change History (8)

comment:1 by fingolfin, 10 years ago

Actually, changes like this break our code formatting conventions:
-AbstractFSNode *AmigaOSFilesystemFactory::makeRootFileNode() const {
+AbstractFSNode *AmigaOSFilesystemFactory::makeRootFileNode() const
+{

comment:2 by raziel-, 10 years ago

I'm sorry, i was told to not clutter up the code and make it hard to read by putting an open { at the end of a line.
I will of course revert that and upload a new diff

by raziel-, 10 years ago

Attachment: AmigaOS4.diff added

New diff file respecting the coding conventions

comment:3 by raziel-, 10 years ago

New diff uploaded, could you please check again and tell me what needs to be done?

Thanks a lot

comment:4 by fingolfin, 10 years ago

Whoever told you that probably wasn't a member of the ScummVM team... ;). In any case, I think either formatting style is just fine, and I have used both on many occasions -- the only thing that I consider important is that inside a single project, you stay consistent.

comment:5 by fingolfin, 10 years ago

D'oh, I had totally forgotten about this one :(. Applied to SVN now, thanks!

comment:6 by fingolfin, 10 years ago

Owner: set to fingolfin
Status: newclosed

comment:7 by digitall, 12 months ago

Component: Port: AmigaOS4
Note: See TracTickets for help on using tickets.