Opened 11 years ago

Closed 11 years ago

Last modified 17 months ago

#9006 closed patch (wontfix)

GSoC 2009: Error message in base/main.cpp

Reported by: SF/danielt3 Owned by: fingolfin
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

Added code to display an error message if the game could not be started properly for some reason. Implemented custom messages for each one of the reasons in Common:Error enumeration. Tested on Windows Vista using Visual C++ 2008 Express.

Ticket imported from: #2759912. Ticket imported from: patches/1111.

Attachments (1)

main_error_dialog.patch (1.9 KB ) - added by SF/danielt3 11 years ago.
Error message patch.

Download all attachments as: .zip

Change History (5)

by SF/danielt3, 11 years ago

Attachment: main_error_dialog.patch added

Error message patch.

comment:1 by SF/danielt3, 11 years ago

Summary: Error message in base/main.cppGSoC 2009: Error message in base/main.cpp

comment:2 by fingolfin, 11 years ago

Thanks for this patch, it served its purpose well and showed that you put some effort into things.

I am still going to reject it for two reasons: It doesn't follow our code formatting conventions, and (more importantly), the given form is not that useful to users, because the error messages are mostly useless for them (i.e., don't help them understand what exactly is the problem and how to fix it). Implementing proper error messages which give some sensible context is certainly a worthwhile project but probably more than can be done with a quick patch :).

comment:3 by fingolfin, 11 years ago

Owner: set to fingolfin
Resolution: wontfix
Status: newclosed

comment:4 by digitall, 17 months ago

Component: GUI
Note: See TracTickets for help on using tickets.