Opened 11 years ago

Closed 10 years ago

Last modified 13 months ago

#9004 closed patch (wontfix)

GSoC 2009: Some additions in the Options Dialog in PSP Port

Reported by: SF/kaustubht Owned by: fingolfin
Priority: normal Component: Port: PSP
Keywords: Cc:
Game:

Description

I have added a tab for the Analog Nub's Sensitivity setting in the Options dialog. The sensitivity goes from .10 to 2.00. This could eventually be used as a multiplier to slow down or speed up the mouse pointer according to the user's wish. Only GUI has been added, no functionality has been implemented as of yet.
Also, TabWidget has a problem in displaying Tab titles whose size is greater than 6 characterson PSP. So "Graphics" Tab has been renamed "GFX" in both options dialog and edit game dialog. The old implementation didn't seem to work, so I just added a few lines in #if defined(__PSP__) and #endif.

This patch has been tested on a PSP. Also tested on Linux to see if compilation for Linux is affected or not.

Ticket imported from: #2759338. Ticket imported from: patches/1109.

Attachments (2)

optionsCPP.diff (1.5 KB ) - added by SF/kaustubht 11 years ago.
patch for gui/options.cpp
optionsH.diff (322 bytes ) - added by SF/kaustubht 11 years ago.
patch for gui/options.h

Download all attachments as: .zip

Change History (8)

by SF/kaustubht, 11 years ago

Attachment: optionsCPP.diff added

patch for gui/options.cpp

by SF/kaustubht, 11 years ago

Attachment: optionsH.diff added

patch for gui/options.h

comment:1 by joostp, 11 years ago

Thanks for the patch.

Looks okay to me. Ideally we'd keep common code free from platform specific #ifdef's as much as possible (not sure how easy/hard it is to avoid in this case), but of course for the scope of this patch it is fine, and it shows you put in some effort.

Note though that in general you'd provide 1 unified diff for all changes, rather than diffing each file that changed individually.

comment:2 by fingolfin, 11 years ago

Kaustubh, do you plan to revise this based on what joost wrote? Or shall we close this tracker item, now that it served its purpose?

Joost?

comment:3 by fingolfin, 11 years ago

Owner: set to joostp

comment:4 by sev-, 11 years ago

What is the status of this item?

comment:5 by fingolfin, 10 years ago

Owner: changed from joostp to fingolfin
Resolution: wontfix
Status: newclosed

comment:6 by digitall, 13 months ago

Component: Port: PSP
Note: See TracTickets for help on using tickets.