Opened 11 years ago

Closed 11 years ago

Last modified 17 months ago

#9002 closed patch (wontfix)

GSOC09: Unused variable warnings

Reported by: SF/landhar Owned by: fingolfin
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

I slightly modified the code in the following files to avoid having an 'unused variable' warning when building the project with g++: - engines/scumm/sound.cpp - engines/sword2/music.cpp

Ticket imported from: #2756844. Ticket imported from: patches/1107.

Attachments (2)

sound.patch (968 bytes ) - added by SF/landhar 11 years ago.
patch for engines/scumm/sound.cpp
music.patch (1.3 KB ) - added by SF/landhar 11 years ago.
patch for engines/sword2/music.cpp

Download all attachments as: .zip

Change History (6)

by SF/landhar, 11 years ago

Attachment: sound.patch added

patch for engines/scumm/sound.cpp

by SF/landhar, 11 years ago

Attachment: music.patch added

patch for engines/sword2/music.cpp

comment:1 by SF/knakos, 11 years ago

Thank you for the patch. Looks good to me.

comment:2 by fingolfin, 11 years ago

The original code produces no warning for me, but after applying the patch I get these warnings: engines/sword2/music.cpp:203: error: redeclaration of ‘Sword2::SafeSubReadStream* tmp’ engines/sword2/music.cpp:198: error: ‘Sword2::SafeSubReadStream* tmp’ previously declared here engines/sword2/music.cpp:208: error: redeclaration of ‘Sword2::SafeSubReadStream* tmp’ engines/sword2/music.cpp:198: error: ‘Sword2::SafeSubReadStream* tmp’ previously declared here

comment:3 by fingolfin, 11 years ago

Owner: set to fingolfin
Resolution: wontfix
Status: newclosed

comment:4 by digitall, 17 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.