#8967 closed patch
Implement getDevices() in backends/midi/dmedia.cpp
| Reported by: | SF/canavan | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Port: IRIX |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
This patch is a first attempt to implement getDevices() for the IRIX midi driver dmedia.cpp.
Ticket imported from: #2658665. Ticket imported from: patches/1072.
Attachments (1)
Change History (6)
comment:1 by , 15 years ago
comment:2 by , 15 years ago
Update patch to fix formatting, add README section on configuration.
I don't see any reference to the equivalent alsa_port in base/commandLine.cpp, or for that matter anywhere outside alsa.cpp and the REAME, so I'm not certain what you expect to be added to the usage help. To be honest, I don'e even know how the ConfMan objects correspond to commandline options. File Added: backends_midi_dmedia.patch
comment:3 by , 15 years ago
Looks good now, committed as is.
I think we shouldn't bother adding this to the usage text. We just have to finally overhaul the music/midi driver system to allow passing driver settings in a formalized way (so no more env variable tricks or custom config strings / command line stuff, and also the ability to change this via the GUI).
comment:4 by , 15 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:5 by , 6 years ago
| Component: | → Port: IRIX |
|---|
Looks pretty good besides one minor code formatting issue at line "if (0==strcmp(var, portName)) {".
But you also need to add description of that dmedia_port to the readme and also make it IRIX-specific at compile time in our scummvm usage help.