Opened 12 years ago

Closed 12 years ago

Last modified 2 years ago

#8964 closed patch

SCI file handling rewrite

Reported by: fingolfin Owned by:
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game:

Description

The attached patch is a first attempt at rewriting file handling code in the SCI engine to use the portable file (& savefile) APIs provided by ScummVM, instead of POSIX file handling APIs.

It is not well-tested nor complete; there are numerous comments explaining caveats and limitations throughout the patch.

Ticket imported from: #2635779. Ticket imported from: patches/1069.

Attachments (1)

sci-file.patch (29.1 KB ) - added by fingolfin 12 years ago.

Download all attachments as: .zip

Change History (6)

by fingolfin, 12 years ago

Attachment: sci-file.patch added

comment:1 by sev-, 12 years ago

The patch looks OK to me, without even applying or running it.

Only thing is kGetCWD(). As dhewg reported on the IRC that he had crashes. But you're aware of this and I am sure he will retest :)

comment:2 by dhewg, 12 years ago

Patch works without crashes on 2 games where i got crashes on the Wii port before. SQ3 can read "version" and LSL3 can create/read "LARRY3.DRV" and "RESOURCE.LL3" just fine :)

comment:3 by fingolfin, 12 years ago

I committed this a bit earlier today, in modified form.

comment:4 by fingolfin, 12 years ago

Status: newclosed

comment:5 by digitall, 2 years ago

Component: Engine: SCI
Note: See TracTickets for help on using tickets.